Refactor to merge All K8s Deployments view to K8s Deployment view

@nileshaddweb

Thank you for the refactoring. Could you please delete the existing view?

Since we replace from views.view.k8s_deployment_all.yml to views.view.k8s_deployment.yml by add the all view to views.view.k8s_deployment.yml and by removing views.view.k8s_deployment_all.yml, the following code needs to work.

+++ b/modules/cloud_service_providers/k8s/src/Plugin/Derivative/K8sMenuLinks.php
@@ -116,8 +116,13 @@ class K8sMenuLinks extends DeriverBase implements ContainerDeriverInterface {
           $title = $entity_definition->getLabel();
           $id = "k8s.local_tasks." . $entity_type;
           $links[$id] = $base_plugin_definition;
-          $links[$id]['title'] = $this->t('@title', ['@title' => $title . "s"]);
-          $links[$id]['route_name'] = "view.{$entity_type}_all.list";
+          $links[$id]['title'] = $this->t('@titles', ['@title' => $title]);
+          if ($entity_type == 'k8s_deployment') {
+            $links[$id]['route_name'] = "view.{$entity_type}.all";
+          }
+          else {
+            $links[$id]['route_name'] = "view.{$entity_type}_all.list";
+          }

The URL should remain /clouds/k8s/deployment.

@nileshaddweb

After merging #3115573, it broke this patch. Could you re-create it?

$ git apply -v /tmp/3115567-5.patch
Checking patch modules/cloud_service_providers/k8s/config/install/views.view.k8s_deployment.yml...
Checking patch modules/cloud_service_providers/k8s/k8s.install...
Hunk #1 succeeded at 1547 (offset 15 lines).
Checking patch modules/cloud_service_providers/k8s/src/Plugin/Derivative/K8sMenuLinks.php...
error: while searching for:
          $title = $entity_definition->getLabel();
          $id = "k8s.local_tasks." . $entity_type;
          $links[$id] = $base_plugin_definition;
          $links[$id]['title'] = $this->t('@title', ['@title' => $title . "s"]);
          $links[$id]['route_name'] = "view.{$entity_type}_all.list";
          $links[$id]['menu_name'] = 'cloud.service_providers.menu.all';
          $links[$id]['parent'] = 'cloud.service_providers.menu.all';
          $links[$id]['weight'] = $weight++;

error: patch failed: modules/cloud_service_providers/k8s/src/Plugin/Derivative/K8sMenuLinks.php:116
error: modules/cloud_service_providers/k8s/src/Plugin/Derivative/K8sMenuLinks.php: patch does not apply

@nileshaddweb

Thank you for the update. I tested it and looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.