While writing tests for this module i found out that the mapping for the 'exclude_request_path' setting is missing.
The patch below fixes this issue.

CommentFileSizeAuthor
#6 3115358-6.patch946 bytesthomas cys
#4 3115358-3.patch601 bytesthomas cys
#2 3115358-2.patch702 bytesthomas cys

Comments

Thomas Cys created an issue. See original summary.

thomas cys’s picture

thomas cys
Primary language Dutch
commented
StatusFileSize
new 3115358-2.patch702 bytes
thomas cys’s picture

thomas cys
Primary language Dutch
commented
Status: Active » Needs review
thomas cys’s picture

thomas cys
Primary language Dutch
commented
StatusFileSize
new 3115358-3.patch601 bytes

Better label naming.

Status: Needs review » Needs work

The last submitted patch, 4: 3115358-3.patch, failed testing. View results

thomas cys’s picture

thomas cys
Primary language Dutch
commented
Status: Needs work » Active
StatusFileSize
new 3115358-6.patch946 bytes

We're actually using a condition plugin so updated the settings.yml and schema.yml accordingly.

thomas cys’s picture

thomas cys
Primary language Dutch
commented
Status: Active » Needs review

  • sandboxpl committed 5757c75 on 8.x-1.x authored by Thomas Cys 
    Issue #3115358 by Thomas Cys: Missing mapping for 'exclude_request_path...
sandboxpl’s picture

sandboxpl
Primary language Polish
Location Poland 🇵🇱
commented
Status: Needs review » Fixed

Another good catch,
this is now committed dev , thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.