The core/themes/classy/css/components/image-widget.css CSS file is not used in this theme (Classy). It was intended to be used,
but due to a bug, Drupal 8 shipped with it not being used. To not break backwards compatibility, we continue to not load it in Classy.
Every subtheme of Classy is encouraged to use it, by attaching the classy/image-widget asset library in their image-widget.html.twig file.

@todo In Drupal 9, let core/themes/classy/templates/content-edit/image-widget.html.twig
attach the classy/image-widget asset library.

CommentFileSizeAuthor
#22 3115341-22.patch2.31 KB_utsavsharma
#22 interdiff_d10.txt1.18 KB_utsavsharma
#15 interdiff_14-15.txt1.45 KBraman.b
#15 3115341-15.patch8.03 KBraman.b
#14 interdiff_11-14.txt3.07 KBraman.b
#14 3115341-14.patch6.65 KBraman.b
#11 interdiff_7-11.txt875 bytesnarendra.rajwar27
#11 3115341-11.patch3.08 KBnarendra.rajwar27
#7 interdiff-5-7.txt752 byteshardik_patel_12
#7 3115341-7.patch2.47 KBhardik_patel_12
#2 3115334-2.patch2.12 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review
StatusFileSize
new 3115334-2.patch2.12 KB

Removing classes added form Prerender callback for Dropbutton element.

Status: Needs review » Needs work

The last submitted patch, 2: 3115334-2.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: Unassigned » hardik_patel_12

working on this.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3115341-7.patch2.47 KB
new interdiff-5-7.txt752 bytes

Re-rolling for 9.1.x-dev

hardik_patel_12’s picture

hardik_patel_12 commented

Kindly review above patch

hardik_patel_12’s picture

hardik_patel_12 commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 7: 3115341-7.patch, failed testing. View results

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new 3115341-11.patch3.08 KB
new interdiff_7-11.txt875 bytes

Status: Needs review » Needs work

The last submitted patch, 11: 3115341-11.patch, failed testing. View results

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

raman.b’s picture

raman.b commented
Status: Needs work » Needs review
StatusFileSize
new 3115341-14.patch6.65 KB
new interdiff_11-14.txt3.07 KB

Resolving failed test cases

raman.b’s picture

raman.b commented
StatusFileSize
new 3115341-15.patch8.03 KB
new interdiff_14-15.txt1.45 KB

Missed this one

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Component: theme system » Umami demo
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Moving to Umami as stark, classy, and bartik have all been removed in D10

markconroy’s picture

markconroy commented

Thanks @smustgrave.

Looks like the patch in this (if needed in Umami) should be much smaller than it currently is. from #15 the patch seems to also be covering bartik, and other themes.

At minimum, let's get that cleaned up.

_utsavsharma’s picture

_utsavsharma commented
StatusFileSize
new interdiff_d10.txt1.18 KB
new 3115341-22.patch2.31 KB

Patch for 10.1.x including only Umami.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.