When listing overridable fields the machine name is used as label which is not user friendly.

CommentFileSizeAuthor
#6 mig-ov-after.png8.73 KBdanflanagan8
#6 mig-ov-before.png9.85 KBdanflanagan8
#2 3115081-2.patch894 bytesmartins.bertins

Comments

martins.bertins created an issue. See original summary.

martins.bertins’s picture

martins.bertins commented
Status: Needs work » Needs review
StatusFileSize
new 3115081-2.patch894 bytes

The attached patch ensures that human readable field labels are used.
Additionally it fetches field definitions array only once instead of for each overridable field.

martins.bertins’s picture

martins.bertins commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: 3115081-2.patch, failed testing. View results

jcandan’s picture

jcandan commented
Status: Needs work » Reviewed & tested by the community

Patch #2 works well.

Before:
Only local images are allowed.

After:
Only local images are allowed.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
StatusFileSize
new mig-ov-before.png9.85 KB
new mig-ov-after.png8.73 KB

Those screenshots in #5 are broken for me at least. Here are some fresh ones:

Before

After

Which look good. I like the patch from a code standpoint. It appears to me that this was always the intention but it didn't work right for some reason I haven't dug in deeply enough to uncover.

I'm assuming the tests I re-triggered are going to pass since that defaultTheme thing has been fixed. +1 for RTBC.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented

As a bonus, this patch appears to fix a bug I was seeing with using migrate_override in conjunction with the moderation_state field:

Error: Call to a member function getLabel() on null in Drupal\migrate_override\OverrideManagerService->getOverridableFields() (line 269 of modules/contrib/migrate_override/src/OverrideManagerService.php).

This patch fixes it, which is cool.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Version: 8.x-1.0 » 2.0.x-dev

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 2.0.x branch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.