Problem/Motivation

This @todo regarding fieldset CSS pops up in a few places. 

 * @todo remove once this Mozilla bug is fixed.
 * See https://bugzilla.mozilla.org/show_bug.cgi?id=504622

The Mozilla bug is fixed

Proposed resolution

Remove the CSS. Provide screenshots to prove the removal is not unpleasant.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 FF-without-workaround.png90.46 KBbnjmnm
#2 FF-with-workaround.png70.53 KBbnjmnm
#2 chrome-as-reference.png94.8 KBbnjmnm
#2 3115005-2.patch1.75 KBbnjmnm

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review
StatusFileSize
new 3115005-2.patch1.75 KB
new chrome-as-reference.png94.8 KB
new FF-with-workaround.png70.53 KB
new FF-without-workaround.png90.46 KB

The rule is removed. Here are some reference screenshots.

Here are fieldsets in Chrome, a browser that was not impacted by the workaround:

These are fieldsets in Firefox with the display: table-cell workaround that is no longer necessary. Notice that there's more top/bottom space separating the fieldsets

These are fieldsets in Firefox with this patch applied, removing the no-longer-necessary workaround. There's no longer a bug, and it now better matches other browsers.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

LGTM.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Yep this is inline with our browser policy - https://www.drupal.org/node/3079238 this was fix ed in Firefox 53 - they're on 74 now.

Committed 00ebcd9b83 and pushed to 9.0.x.
Committed c81afb8 and pushed to 8.9.x. Thanks!

  • alexpott committed c81afb8 on 8.9.x 
    Issue #3115005 by bnjmnm: Remove fieldset CSS that was only there to...

  • alexpott committed 00ebcd9 on 9.0.x 
    Issue #3115005 by bnjmnm: Remove fieldset CSS that was only there to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.