\Drupal\Tests\node\Functional\PagePreviewTest::testPagePreviewWithRevisions random fails on PHP 7.4 due to
1x: implode(): Passing glue string after array is deprecated. Swap the parameters
1x in PagePreviewTest::testPagePreviewWithRevisions from Drupal\Tests\node\Functional
This happens because of code in \Behat\Mink\Selector\Xpath\Escaper::escapeLiteral() has an implode with the args the wrong way around and we're generating a random string with quote a single quote and double quote in it.
Update behat/mink once either https://github.com/minkphp/Mink/pull/792 or https://github.com/minkphp/Mink/pull/794 has landed. We're on a dev release aleady.
None
None
None
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3115000-2.will-fail-on-7.4.patch | 794 bytes | alexpott |
Comments
Comment #2
alexpottThe patch attached will fail on PHP 7.4
Comment #3
alexpottComment #4
sam-elayyoub commentedHey @alexpott, the issue with PHP 7.4 and your patch didn't pass PHP 7.4 so I'm going to move this issue to need work.
Comment #5
sam-elayyoub commentedPHP 7.4 failed
Comment #6
alexpott@sam-elayyoub yeah that was expected :) the patch was called will-fail-on-7.4. We can't really fix this in core - we need an upstream fix.
Comment #7
krzysztof domańskiThere's another one but in
\Drupal\Tests\node\Functional\NodeAccessMenuLinkTest::testNodeAccessMenuLink.https://www.drupal.org/pift-ci-job/1573030
Comment #8
alexpottThis will be fixed by #3078671: Pin behat/mink and behat/mink-selenium2-driver to use resolvable release - it is already in D9.