Problem/Motivation

\Drupal\Tests\node\Functional\PagePreviewTest::testPagePreviewWithRevisions random fails on PHP 7.4 due to 

    1x: implode(): Passing glue string after array is deprecated. Swap the parameters
    1x in PagePreviewTest::testPagePreviewWithRevisions from Drupal\Tests\node\Functional

This happens because of code in \Behat\Mink\Selector\Xpath\Escaper::escapeLiteral() has an implode with the args the wrong way around and we're generating a random string with quote a single quote and double quote in it.

Proposed resolution

Update behat/mink once either https://github.com/minkphp/Mink/pull/792 or https://github.com/minkphp/Mink/pull/794 has landed. We're on a dev release aleady.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

CommentFileSizeAuthor
#2 3115000-2.will-fail-on-7.4.patch794 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3115000-2.will-fail-on-7.4.patch794 bytes

The patch attached will fail on PHP 7.4

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +Random test failure
sam-elayyoub’s picture

sam-elayyoub commented

Hey @alexpott, the issue with PHP 7.4 and your patch didn't pass PHP 7.4 so I'm going to move this issue to need work.

sam-elayyoub’s picture

sam-elayyoub commented
Status: Needs review » Needs work

PHP 7.4 failed

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@sam-elayyoub yeah that was expected :) the patch was called will-fail-on-7.4. We can't really fix this in core - we need an upstream fix.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented

There's another one but in \Drupal\Tests\node\Functional\NodeAccessMenuLinkTest::testNodeAccessMenuLink.

4x: implode(): Passing glue string after array is deprecated. Swap the parameters
  4x in NodeAccessMenuLinkTest::testNodeAccessMenuLink from Drupal\Tests\node\Functional

https://www.drupal.org/pift-ci-job/1573030

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Closed (duplicate)

This will be fixed by #3078671: Pin behat/mink and behat/mink-selenium2-driver to use resolvable release - it is already in D9.