This module gives errors when the url_with_class field is empty , both on render and on the settingsform.

This patch checks on empty.

CommentFileSizeAuthor
#5 interdiff-4-5.txt2.76 KBhardik_patel_12
#5 3114827-5.patch1.61 KBhardik_patel_12
#4 2020-02-21_13-15-03.jpg763.77 KBdanny englander
#4 3114827-4.patch2.3 KBdanny englander
#2 3114827-1.patch1.16 KBdimitri.baudonck@gmail.com

Comments

dimitri.baudonck@dukeandgrace.com created an issue. See original summary.

dimitri.baudonck@gmail.com’s picture

dimitri.baudonck@gmail.com
Location Ghent
commented
StatusFileSize
new 3114827-1.patch1.16 KB
dimitri.baudonck@gmail.com’s picture

dimitri.baudonck@gmail.com
Location Ghent
commented
Status: Patch (to be ported) » Needs review

Added organisation.

danny englander’s picture

danny englander
(he/him)
commented
StatusFileSize
new 3114827-4.patch2.3 KB
new 2020-02-21_13-15-03.jpg763.77 KB

I tested the patch but it did not apply using Composer so I re-rolled it. After testing, the error went away from both areas. The error was 

Notice: Undefined offset: 1 in page_specific_class_preprocess_html() (line 30 of modules/contrib/page_specific_class/page_specific_class.module).

Note, I also fixed a few PHPCS items that had been flagged.

before and after

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3114827-5.patch1.61 KB
new interdiff-4-5.txt2.76 KB

Patch at #4 was not applying ,so i have added new logic which is checking not empty value on configuration form. Kindly review a new patch.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Good to go!

  • Hardik_Patel_12 authored 977cb4d on 2.0.x 
    Issue #3114827 by Hardik_Patel_12, Danny Englander, dimitri.baudonck@...
hardik_patel_12’s picture

hardik_patel_12 commented
Status: Reviewed & tested by the community » Fixed

Thank-you everyone for your wonderful effort, this patch is pushed on 2.0.x branch.

promo-il’s picture

promo-il commented

patch#5 D:8.8, PHP:7.2 OK

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.