CommentFileSizeAuthor
#5 3114583-5.patch6.36 KBsaurabh.rocksoul
#5 interdiff_2-5.txt2.75 KBsaurabh.rocksoul
#2 3114583-2.patch3.46 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review
StatusFileSize
new 3114583-2.patch3.46 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch

Status: Needs review » Needs work

The last submitted patch, 2: 3114583-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

saurabh.rocksoul’s picture

saurabh.rocksoul
Primary language English
Location Indore, India
commented
Status: Needs work » Needs review
Issue tags: +VbContribution2020
StatusFileSize
new interdiff_2-5.txt2.75 KB
new 3114583-5.patch6.36 KB

Thank you @Hardik_Patel_12 for the patch to remove deprecated code.
The test might have failed because you didn't removed deprecated test functions from the test files.
Uploading a new patch. Please review.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Closed (duplicate)

Thank you for working on this, but removing this deprecation is already covered in the wider issue at #3104307: Remove BC layers in various Drupal\Core components

If you have time to review that issue it would be appreciated!