Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

StatusFileSize
new1.32 KB

Kindly review a patch.

hardik_patel_12’s picture

Status: Active » Needs review
longwave’s picture

Status: Needs review » Needs work
$this->id = $this->initialAccountId = $account_id;

We need to remove the mention of initialAccountId from this line as this property no longer exists.

swatichouhan012’s picture

Status: Needs work » Needs review
StatusFileSize
new1.64 KB
new485 bytes

@longwave i have removed initialAccountId, Kindly review patch.

longwave’s picture

Status: Needs review » Needs work

I don't think this will work - we still need to store the ID, but not in the removed variable. The line needs to be:

$this->id = $account_id;
swatichouhan012’s picture

Status: Needs work » Needs review
StatusFileSize
new1.67 KB
new457 bytes

Thanks @longwave to notice the issue, i have accidental removed complete line, updated patch please remove.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Looks good now. RTBC if tests pass.

The last submitted patch, 5: 3114237-5.patch, failed testing. View results

alexpott’s picture

Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3104307: Remove BC layers in various Drupal\Core components

This is a a duplicate of #3104307: Remove BC layers in various Drupal\Core components - as this is a trivial code removal there is no value in handling this as a separate issue. In fact doing so causes unnecessary re-rolls and work in that issue.

@Hardik_Patel_12 , @swatichouhan012 thanks for your contributions - when working on deprecations I encourage you to check #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch for existing issues - I recognise that is hard though - but most (if not all the simpler code removals have an existing issue).