| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff_5-7.txt | 457 bytes | swatichouhan012 |
| #7 | 3114237-7.patch | 1.67 KB | swatichouhan012 |
| #5 | interdiff_2-5.txt | 485 bytes | swatichouhan012 |
| #5 | 3114237-5.patch | 1.64 KB | swatichouhan012 |
| #2 | 3114237-2.patch | 1.32 KB | hardik_patel_12 |
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff_5-7.txt | 457 bytes | swatichouhan012 |
| #7 | 3114237-7.patch | 1.67 KB | swatichouhan012 |
| #5 | interdiff_2-5.txt | 485 bytes | swatichouhan012 |
| #5 | 3114237-5.patch | 1.64 KB | swatichouhan012 |
| #2 | 3114237-2.patch | 1.32 KB | hardik_patel_12 |
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch.
Comment #3
hardik_patel_12 commentedComment #4
longwaveWe need to remove the mention of
initialAccountIdfrom this line as this property no longer exists.Comment #5
swatichouhan012 commented@longwave i have removed initialAccountId, Kindly review patch.
Comment #6
longwaveI don't think this will work - we still need to store the ID, but not in the removed variable. The line needs to be:
Comment #7
swatichouhan012 commentedThanks @longwave to notice the issue, i have accidental removed complete line, updated patch please remove.
Comment #8
longwaveLooks good now. RTBC if tests pass.
Comment #10
alexpottThis is a a duplicate of #3104307: Remove BC layers in various Drupal\Core components - as this is a trivial code removal there is no value in handling this as a separate issue. In fact doing so causes unnecessary re-rolls and work in that issue.
@Hardik_Patel_12 , @swatichouhan012 thanks for your contributions - when working on deprecations I encourage you to check #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch for existing issues - I recognise that is hard though - but most (if not all the simpler code removals have an existing issue).