Need to remove getMessageIterator() deprecated in drupal:8.8.0 and removed from drupal:9.0.0

CommentFileSizeAuthor
#9 interdiff.3114017.5-9.txt15.37 KBlongwave
#9 3114017-9.patch17.88 KBlongwave
#5 3114017-4.patch3.38 KBhash6
#3 3114017-3.patch3.47 KBhash6

Comments

hash6 created an issue. See original summary.

hash6’s picture

hash6 commented

getMessageIterator() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. in
- core/modules/migrate/tests/src/Unit/MigrateNullIdMapTest.php
- core/modules/migrate/tests/src/Unit/MigrateSqlIdMapTest.php
- core/modules/migrate/src/Plugin/migrate/id_map/Sql.php
- core/modules/migrate/src/Plugin/migrate/id_map/NullIdMap.php

hash6’s picture

hash6 commented
StatusFileSize
new 3114017-3.patch3.47 KB
hash6’s picture

hash6 commented
Status: Needs work » Needs review
hash6’s picture

hash6 commented
StatusFileSize
new 3114017-4.patch3.38 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Fairly simple deprecation, all mentions of getMessageIterator are removed after this patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: getMessageIterator() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. in core/modules/migrate/tests/src/Unit/MigrateSqlIdMapTest.php » Remove deprecated getMessageIterator() from migrate
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Remove deprecated getMessageIterator() from migrate » Remove deprecated code from migrate module
Status: Reviewed & tested by the community » Needs work
Related issues: +#3111344: Remove deprecated code from migrate module

Let's widen this issue to cover the deprecated code paths that are still left in migrate module rather doing every code path in the module one-by-one. This is a follow-up from #3111344: Remove deprecated code from migrate module

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3114017-9.patch17.88 KB
new interdiff.3114017.5-9.txt15.37 KB

Fixed all remaining deprecations in the module, except one in MigrateDestinationInterface:

   * @param \Drupal\migrate\Plugin\MigrationInterface $migration
   *   Unused, will be removed before Drupal 9.0.x. Defaults to NULL.

I guess this is also safe to refactor away now? There are many implementations that all need updating, and I haven't found where this is called but I guess if it still passes in a migration that should be removed now too.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good! :-)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +Needs followup

@longwave nice find on \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() - can we get a follow-up for that - or look in the existing issue queue. I've not managed to find where this method is even called from yet.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

+1 to RTBC, looks good other than the lack of the identified followup.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs followup

I've created the follow-up #3114974: \Drupal\migrate\Plugin\MigrateDestinationInterface::fields() $migration argument is deprecated.

Committed 9483ed9 and pushed to 9.0.x. Thanks!

  • alexpott committed 9483ed9 on 9.0.x 
    Issue #3114017 by hash6, longwave, alexpott: Remove deprecated code from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.