CommentFileSizeAuthor
#2 3113999-2.patch852 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3113999-2.patch852 bytes

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review
hardik_patel_12’s picture

hardik_patel_12 commented
Title: Remove all @deprecated code from Image component » Remove all @deprecated code from FileTransfer component
Component: image system » file system
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/lib/Drupal/Core/FileTransfer/Local.php
@@ -22,12 +22,8 @@ class Local extends FileTransfer implements ChmodInterface {
    * {@inheritdoc}
    */
-  public function __construct($jail, FileSystemInterface $file_system = NULL) {
+  public function __construct($jail, FileSystemInterface $file_system) {

this @inheritdoc needs follow-up to fix, because \Drupal\Core\FileTransfer\FileTransfer::__construct() using different number of arguments, and all its child classes has own arguments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3104307: Remove BC layers in various Drupal\Core components

This is a a duplicate of #3104307: Remove BC layers in various Drupal\Core components - as this is a trivial code removal there is no value in handling this as a separate issue. In fact doing so causes unnecessary re-rolls and work in that issue.

@Hardik_Patel_12 thanks for your contribution - when working on deprecations I encourage you to check #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch for existing issues - I recognise that is hard though - but most (if not all the simpler code removals have an existing issue).