CommentFileSizeAuthor
#13 Screen Shot 2020-06-18 at 12.13.38.png41.64 KBlauriii
#10 D9.1.x_After Iphone X.png124.52 KBpriyanka.sahni
#10 D9.1.x_After Iphone 6:7:8 Plus.png134.37 KBpriyanka.sahni
#10 D9.1.x_After Iphone 6:7:8 .png132.17 KBpriyanka.sahni
#10 D9.1.x_After Iphone 5S:SE.png127.24 KBpriyanka.sahni
#10 D9.1.x Iphone X.png126.62 KBpriyanka.sahni
#10 D9.1.x Iphone 6:7:8.png134.35 KBpriyanka.sahni
#10 D9.1.x Iphone 5S:SE.png127.9 KBpriyanka.sahni
#10 D8.9_After Iphone X.png131.76 KBpriyanka.sahni
#10 D8.9_After Iphone 6:7:8 Plus.png139.93 KBpriyanka.sahni
#10 D8.9_After Iphone 6:7:8.png137.66 KBpriyanka.sahni
#10 D8.9_After Iphone 5S:SE.png120.09 KBpriyanka.sahni
#10 D8.9 Iphone X.png128.49 KBpriyanka.sahni
#10 D8.9 Iphone 6:7:8.png122.54 KBpriyanka.sahni
#10 D8.9 Iphone 5S:SE.png97.25 KBpriyanka.sahni
#5 3113840-5.patch1.58 KBhimanshu_sindhwani
#3 short-icon-after.PNG20.88 KBvani.s
#2 shortcuts_icon-3113840-1.patch446 bytesvani.s
shortcut-icon.PNG21.97 KBvani.s

Comments

vani.S created an issue. See original summary.

vani.s’s picture

vani.s commented
StatusFileSize
new shortcuts_icon-3113840-1.patch446 bytes

Hi,

I made a patch for this. Please check and tell me as works fine to commit.

Thanks!!

vani.s’s picture

vani.s commented
Status: Active » Needs review
StatusFileSize
new short-icon-after.PNG20.88 KB
himanshu_sindhwani’s picture

himanshu_sindhwani commented
Version: 8.7.x-dev » 8.9.x-dev
Assigned: Unassigned » himanshu_sindhwani
Status: Needs review » Needs work

The patch is failing the test cases and additionally, it should be made against the latest dev branch for bugs which is 8.9.x.

himanshu_sindhwani’s picture

himanshu_sindhwani commented
StatusFileSize
new 3113840-5.patch1.58 KB

Here is a patch which fixes the issue.

himanshu_sindhwani’s picture

himanshu_sindhwani commented
Assigned: himanshu_sindhwani » Unassigned
Status: Needs work » Needs review
sharma.amitt16’s picture

sharma.amitt16 commented

Can we test the bug for 9.1x as well?

If the bug is available in 9.1.x then we should fix this for the same as well.

sharma.amitt16’s picture

sharma.amitt16 commented

Added test for 9.1.x in #5 and the status is passed.

priyanka.sahni’s picture

priyanka.sahni commented
Assigned: Unassigned » priyanka.sahni
priyanka.sahni’s picture

priyanka.sahni commented
StatusFileSize
new D8.9 Iphone 5S:SE.png97.25 KB
new D8.9 Iphone 6:7:8.png122.54 KB
new D8.9 Iphone X.png128.49 KB
new D8.9_After Iphone 5S:SE.png120.09 KB
new D8.9_After Iphone 6:7:8.png137.66 KB
new D8.9_After Iphone 6:7:8 Plus.png139.93 KB
new D8.9_After Iphone X.png131.76 KB
new D9.1.x Iphone 5S:SE.png127.9 KB
new D9.1.x Iphone 6:7:8.png134.35 KB
new D9.1.x Iphone X.png126.62 KB
new D9.1.x_After Iphone 5S:SE.png127.24 KB
new D9.1.x_After Iphone 6:7:8 .png132.17 KB
new D9.1.x_After Iphone 6:7:8 Plus.png134.37 KB
new D9.1.x_After Iphone X.png124.52 KB

Verified and tested by applying the patch #5 on Drupal 8.9 and Drupal 9.1.x.Tested on Iphone X , Iphone 6/7/8 , Iphone 6/7/8 Plus and Iphone 5S/SE.It looks good to me.Can be moved to RTBC.

Steps to test-
1. Go to admin site.
2. Go to admin/structure/types.
3. Verify on Mobile view.

Refer to the attached screenshots :

After 8.9 Iphone 5S/SE -
After Patch

After 8.9 Iphone 6/7/8 -
After Patch

After 8.9 Iphone 6/7/8 Plus-
After Patch

After 8.9 Iphone X-
After Patch

After 9.1.x -

After 9.1.x Iphone 5S/SE -
After Patch

After 9.1.x Iphone 6/7/8 -
After Patch

After 9.1.x Iphone 6/7/8 Plus-
After Patch

After 9.1.x Iphone X-
After Patch

priyanka.sahni’s picture

priyanka.sahni commented
Assigned: priyanka.sahni » Unassigned
Status: Needs review » Reviewed & tested by the community
hansa11’s picture

hansa11 commented

Patch #5 applies well for me on Drupal 9.1.x.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3113840: Shortcuts icon not aligned properly in iPhone
StatusFileSize
new Screen Shot 2020-06-18 at 12.13.38.png41.64 KB

Thank you for working on this! I think this issue can be reproduced on any device that has a small enough screen, therefore I think this is a duplicate of #3068698: Better shortcut action link styles when there's limited horizontal space.

The root cause for the problem is that there's a focus effect on the shortcut link. If we change the display to inline, the focus text could be displayed on the next row which isn't ideal:

himanshu_sindhwani’s picture

himanshu_sindhwani commented
Related issues: -#3113840: Shortcuts icon not aligned properly in iPhone +#3068698: Better shortcut action link styles when there's limited horizontal space