Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

StatusFileSize
new4.3 KB

KIndly review a patch.

hardik_patel_12’s picture

Status: Active » Needs review
hash6’s picture

Assigned: Unassigned » hash6
hash6’s picture

Assigned: hash6 » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks @Hardik_Patel_12 for the patch. RTBC done.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php
@@ -498,9 +498,6 @@ protected function rebuildAll() {
     // Explicitly call register() again on the container registered in \Drupal.
-    // @todo This should already be called through
-    //   DrupalKernel::prepareLegacyRequest() -> DrupalKernel::boot() but that
-    //   appears to be calling a different container.

Let's try doing the @todo here now this code flow has obviously changed and try removing the call to
$this->container->get('stream_wrapper_manager')->register(); as well.

If that doesn't work out let's change the @todo here to be:

    // @todo This should already be called through DrupalKernel::boot() but that
    //   appears to be calling a different container.

That said I think it will work out because in \Drupal\Core\Test\FunctionalTestSetupTrait::resetAll() we do $this->container = \Drupal::getContainer();

longwave’s picture

Status: Needs work » Needs review
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
StatusFileSize
new4.47 KB
new686 bytes

Status: Needs review » Needs work

The last submitted patch, 7: 3113583-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

longwave’s picture

Status: Needs work » Needs review

Seemingly unrelated fail, requeuing

Status: Needs review » Needs work

The last submitted patch, 7: 3113583-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

longwave’s picture

So the fail is stream wrapper related; the test generates an image derivative and then modifies the image style, and then fails where the image derivative should have been deleted but wasn't.

I guess debugging this here is out of scope so we should put the reregistration and the @todo back in.

longwave’s picture

Status: Needs work » Closed (duplicate)

This was done as part of a wider issue in #3104307: Remove BC layers in various Drupal\Core components