Closed (duplicate)
Project:
Drupal core
Version:
9.0.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Feb 2020 at 05:45 UTC
Updated:
21 Feb 2020 at 15:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKIndly review a patch.
Comment #3
hardik_patel_12 commentedComment #4
hash6 commentedComment #5
hash6 commentedThanks @Hardik_Patel_12 for the patch. RTBC done.
Comment #6
alexpottLet's try doing the @todo here now this code flow has obviously changed and try removing the call to
$this->container->get('stream_wrapper_manager')->register();as well.If that doesn't work out let's change the @todo here to be:
That said I think it will work out because in
\Drupal\Core\Test\FunctionalTestSetupTrait::resetAll()we do$this->container = \Drupal::getContainer();Comment #7
longwaveComment #9
longwaveSeemingly unrelated fail, requeuing
Comment #11
longwaveSo the fail is stream wrapper related; the test generates an image derivative and then modifies the image style, and then fails where the image derivative should have been deleted but wasn't.
I guess debugging this here is out of scope so we should put the reregistration and the @todo back in.
Comment #12
longwaveThis was done as part of a wider issue in #3104307: Remove BC layers in various Drupal\Core components