Problem/Motivation

The outputstyle for the css is 'compressed'.
See the Gruntfile.js
outputStyle: 'compressed'

If you look at other modules, none of the css is compressed.
Also, when someone makes a patch, is hard to see what actually has changed since the code is one line.

Proposed resolution

Use outputStyle: 'expanded' so the compiled css isn't compressed anymore and patches are better to review.

Remaining tasks

Write a patch which changes the outputStyle and re-generate all the css

CommentFileSizeAuthor
#4 don't_compress_the_compiled_css-3113315-4.patch33.36 KBdennis cohn

Comments

Dennis Cohn created an issue. See original summary.

dennis cohn’s picture

dennis cohn commented

@jakubhnilicka what do you think about this one?

jakubhnilicka’s picture

jakubhnilicka commented

@dennis-cohn first of all I wan't to thank you for contributing.

I think it is good idea. We can also remove cssnano from package.json and from Gruntfile.js then.

Thank you.

dennis cohn’s picture

dennis cohn commented
StatusFileSize
new don't_compress_the_compiled_css-3113315-4.patch33.36 KB

No thanks! I like this module and wanted to contribute more! :)

Ok, I've:

  1. Removed cssnano from package.json and from Gruntfile.js.
  2. Updated packages to solve the vulnerabilities (#3113005)
  3. changed outputStyle: 'compressed 'to outputStyle: 'expanded'
  4. Added the needed packages to actually run grunt (see #3112965)
  5. regenerated all css files
  6. made a patch

Maybe it's good the make a new release, so we can close #3112965 and see if #3111859 still applies?

jakubhnilicka’s picture

jakubhnilicka commented
Status: Active » Closed (works as designed)

Fixed in alpha6 release.

jakubhnilicka’s picture

jakubhnilicka commented
Status: Closed (works as designed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.