Drupal 9 Deprecated Code Report for YAML Content

Working on this.

Here's what drupal-check currently shows:

 36/36 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/yaml_content/process/File.php                                                                       
 ------ --------------------------------------------------------------------------------------------------------------- 
  48     Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from              
         drupal:9.0.0. Use \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.                                     
  48     Call to deprecated function file_prepare_directory():                                                          
         in drupal:8.7.0 and is removed from drupal:9.0.0.                                                              
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().                                                 
  51     Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0.  
         Use \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.                                                     
 ------ --------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------- 
  Line   src/Service/LoadHelper.php                                            
 ------ ---------------------------------------------------------------------- 
  142    Call to deprecated function file_scan_directory():                    
         in drupal:8.8.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.   
  164    Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
  174    Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
 ------ ---------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/Plugin/yaml_content/process/FileTest.php                                              
 ------ ----------------------------------------------------------------------------------------------------------- 
         Class Drupal\Tests\yaml_content\Kernel\Plugin\yaml_content\process\FileTest was not found while trying to  
         analyse it - autoloading is probably not configured properly.                                              
 ------ ----------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   tests/src/Unit/ContentLoader/ContentLoaderTest.php                                    
 ------ -------------------------------------------------------------------------------------- 
  103    Call to deprecated method setExpectedException() of class Drupal\Tests\UnitTestCase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                     
         Backward compatibility for PHPUnit 4 will no longer be supported.                     
  115    Call to deprecated method setExpectedException() of class Drupal\Tests\UnitTestCase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                     
         Backward compatibility for PHPUnit 4 will no longer be supported.                     
 ------ -------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   tests/src/Unit/Plugin/yaml_content/process/FileTest.php                               
 ------ -------------------------------------------------------------------------------------- 
  51     Call to deprecated method setExpectedException() of class Drupal\Tests\UnitTestCase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                     
         Backward compatibility for PHPUnit 4 will no longer be supported.                     
  63     Call to deprecated method setExpectedException() of class Drupal\Tests\UnitTestCase:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                     
         Backward compatibility for PHPUnit 4 will no longer be supported.                     
 ------ -------------------------------------------------------------------------------------- 


 [ERROR] Found 11 errors                                                                                                

FYI I've enabled D9 tests for this module, which will make it easier to confirm it all works.

Maybe it was for the 8.x-2.x branch?

I split off the core_version_requirement line into a separate issue so that we can commit it first: #3125818: Update yaml_content.info.yml to be compatible with D9

Rerolled after committing the info file change.

The rerolled patch works with D8.8, let's see if it passes with D9.

Fixes the two theme variables, let's see if the third item is fixed too.

So with the other changes ContentLoaderTest::testMissingContentFile() no longer throws an exception, instead it gives an error.

Commenting out that test for now, I figured we could add it back in again separately.

I think the reason the test failed was that the assertTaxonomy() method should have had an EntityInterface as its first argument, let's see if the tests pass now.

This should fix the EntityReferenceTestTrait problem.

Trying to fix additional deprecated test methods, per https://www.drupal.org/node/3056869.

Let's see if this resolves the exceptional problem.

The D8.8 tests pass, let's try the D9.0 tests.

Ok, replacing @expectedException with $this->expectException().

D8.8 still passes, hopefully this will be enough for D9.0.

And the tests pass for D9! Woot! Committed.

I reran drupal-check and it found the following:

 ------ --------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/yaml_content/process/File.php                                                                       
 ------ --------------------------------------------------------------------------------------------------------------- 
  48     Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from              
         drupal:9.0.0. Use \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.                                     
  48     Call to deprecated function file_prepare_directory():                                                          
         in drupal:8.7.0 and is removed from drupal:9.0.0.                                                              
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().                                                 
  51     Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0.  
         Use \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.                                                     
 ------ --------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------- 
  Line   src/Service/LoadHelper.php                                            
 ------ ---------------------------------------------------------------------- 
  142    Call to deprecated function file_scan_directory():                    
         in drupal:8.8.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.   
  164    Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
  174    Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
 ------ ---------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/Plugin/yaml_content/process/FileTest.php                                              
 ------ ----------------------------------------------------------------------------------------------------------- 
         Class Drupal\Tests\yaml_content\Kernel\Plugin\yaml_content\process\FileTest was not found while trying to  
         analyse it - autoloading is probably not configured properly.                                              
 ------ ----------------------------------------------------------------------------------------------------------- 

Back to needing more work.

This covers everything except for the FileTest.php, and I'm not sure why that one isn't being recognized when ReferenceTest.php is.

Committed.

I think the warning about FileTest is incorrect, given that it shows in the test results:

11:45:31 Tests to be run:
11:45:31   - Drupal\Tests\yaml_content\Unit\Plugin\yaml_content\process\ReferenceTest
11:45:31   - Drupal\Tests\yaml_content\Unit\Plugin\yaml_content\process\FileTest
[..]
11:45:31 Test summary
11:45:31 ------------
[..]
11:45:32 Drupal\Tests\yaml_content\Unit\Plugin\yaml_content\process\F   2 passes                                      
11:45:32 Drupal\Tests\yaml_content\Unit\Plugin\yaml_content\process\R   3 passes                                      

All done.

It turned out there are *two* FileTest.php files, I missed the other one and TR pointed out the problem - the namespace was wrong. I moved this into a separate issue as it's a generic problem that isn't strictly D9 related: #3127248