Problem/Motivation

phpcs fails on head due to Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected - this is because the sniff has been improved and we've updated our dependencies.

Proposed resolution

Fix it.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3112829-2.patch3.04 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Active » Needs review
FileSize
3112829-2.patch3.04 KB

Here we go...

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

LGTM

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented 
core8$ vendor/bin/phpcs -s --standard=core/phpcs.xml.dist --extensions=module,inc,php,install core

FILE: /home/andypost/www/core8/core/tests/bootstrap.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 150 | WARNING | [x] Empty PHP statement detected: superfluous semi-colon.
     |         |     (Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected)
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/andypost/www/core8/core/modules/taxonomy/taxonomy.post_update.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 252 | WARNING | [x] Empty PHP statement detected: superfluous semi-colon.
     |         |     (Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected)
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/andypost/www/core8/core/modules/migrate/src/Plugin/migrate/id_map/Sql.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 978 | WARNING | [x] Empty PHP statement detected: superfluous semi-colon.
     |         |     (Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected)
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/andypost/www/core8/core/modules/views/tests/src/Kernel/ViewsConfigDependenciesIntegrationTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 151 | WARNING | [x] Empty PHP statement detected: superfluous semi-colon.
     |         |     (Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected)
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/andypost/www/core8/core/modules/workspaces/src/EntityOperations.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 283 | WARNING | [x] Empty PHP statement detected: superfluous semi-colon.
     |         |     (Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected)
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/andypost/www/core8/core/modules/field/field.module
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 304 | WARNING | [x] Empty PHP statement detected: superfluous semi-colon.
     |         |     (Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected)
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------

Time: 2 mins, 40.89 secs; Memory: 138MB

After patch all of them gone

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Version: 9.0.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4cfaf1e679 to 9.0.x and eedcbbf4fc to 8.9.x and 35bd80bed1 to 8.8.x. Thanks!

As a tiny no risk fix backported to 8.8.x

  • alexpott committed 4cfaf1e on 9.0.x 
    Issue #3112829 by alexpott: Fix fails due to Generic.CodeAnalysis....

  • alexpott committed eedcbbf on 8.9.x 
    Issue #3112829 by alexpott: Fix fails due to Generic.CodeAnalysis....

  • alexpott committed 35bd80b on 8.8.x 
    Issue #3112829 by alexpott: Fix fails due to Generic.CodeAnalysis....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.