Replace deprecated function file_scan_directory() with Drupal\Core\File\FileSystemInterface::scanDirectory()

use Drupal\Core\File\FileSystemInterface; - Don't used in file
string: catch (FileException $e) - expect
use Symfony\Component\HttpFoundation\File\Exception\FileException;

Thanks for the work so far, but I am not yet entirely happy with the service usage within the class. It should be defined in high_contrast.services.yml instead.

Please review attached patch.

Sounds like a good idea. Just curious, is there any performance reasons or it's just how it's meant to work if service has been defined?

There is 1 missing space that is bugging me but that's just me https://git.drupalcode.org/project/high_contrast/blob/8.x-1.x/high_contr... :)

Sounds like a good idea. Just curious, is there any performance reasons or it's just how it's meant to work if service has been defined?

I think (but I am far from a Symfony expert) that it helps to reduce the amount of instantiated classes and thus memory usage. By reusing classes and listing all their dependencies they can be loaded in the right order and the same FileSystem class can be reused across all modules. So I think it helps in reducing memory usage. (A 1:1 replacement like this one won't make much of a difference, but it is good to stick to conventions anyway)

I have corrected the space as well :)

Unassigning edemidenko. Thanks all for the help.