CommentFileSizeAuthor
#13 3112683-13.patch3.44 KBandypost
#13 interdiff.txt2.7 KBandypost
#9 interdiff-3112683-2-9.txt2.69 KBhardik_patel_12
#9 3112683-9.patch6.31 KBhardik_patel_12
#2 3112683-2.patch8.53 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3112683-2.patch8.53 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review
nishantghetiya’s picture

nishantghetiya commented
Assigned: Unassigned » nishantghetiya
nishantghetiya’s picture

nishantghetiya commented
Status: Needs review » Reviewed & tested by the community

@Hardik_Patel_12,

Above provided patch is working fine. Thanks for your valuable contribution.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch

As far as I can see there is no existing issue on #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch.

However there has never been a green test for the patch in #2 and now it doesn't apply.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Some of this has been attempted in #3104307: Remove BC layers in various Drupal\Core components

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

And the \Drupal\Core\Field\PluginSettingsInterface is very complicated and probably needs undeprecating since the suggested replacement is not a drop in but needs work like #1764380: Merge PluginSettingsInterface into ConfigurableInterface

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3112683-9.patch6.31 KB
new interdiff-3112683-2-9.txt2.69 KB

Kindly review a new patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@Hardik_Patel_12 this patch is going to fail because PluginSettingsInterface - this patch should leave that alone.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: nishantghetiya » Unassigned
andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#1764380: Merge PluginSettingsInterface into ConfigurableInterface
StatusFileSize
new interdiff.txt2.7 KB
new 3112683-13.patch3.44 KB

Removed hunk because there's separate issue for it #1764380: Merge PluginSettingsInterface into ConfigurableInterface

But looks #11 is right about undeprecate

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 00bcb11 and pushed to 9.0.x. Thanks!

FILE: ...ex/dev/drupal/core/lib/Drupal/Core/Field/BaseFieldDefinition.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 289 | ERROR | [x] Expected 1 blank line after function; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Fixed the coding standard issue on commit.

  • alexpott committed 00bcb11 on 9.0.x 
    Issue #3112683 by Hardik_Patel_12, andypost, alexpott: Remove all @...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.