Closed (fixed)
Project:
Drupal core
Version:
9.0.x-dev
Component:
menu system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Feb 2020 at 05:25 UTC
Updated:
27 Feb 2020 at 11:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch.
Comment #3
hardik_patel_12 commentedComment #5
dhirendra.mishra commented@hardik, Comment there in code itself explain that we had converted from array to string as "The possibility to pass an array as source value to the plugin will be removed in drupal:9.0.0. Pass a string value instead." So we don't have to remove entire code. As test case failed due to removing of reset() from your patch as $value is array.
Comment #6
dhirendra.mishra commentedPlease review updated patch.
Comment #7
nishantghetiya commentedComment #8
nishantghetiya commented@dhirendra.mishra @Hardik_Patel_12, #6 patch works fine. Thanks for your valuable contribution.
Comment #9
nishantghetiya commentedComment #10
alexpottWe need to remove the entire if here. That behaviour is deprecated. And remove the corresponding test - i.e. \Drupal\Tests\menu_link_content\Kernel\Plugin\migrate\process\LinkUriTest::testRoutedLegacy()
Comment #11
dhirendra.mishra commentedComment #12
dhirendra.mishra commentedFixed as per mentioned in #10 and interdiff from #2 patch.
Comment #13
alexpottComment #14
hash6 commentedComment #15
hash6 commentedThanks @dhirendra.mishra , I see the suggestions by @alexpott have been successfully applied in patch.
Comment #16
hash6 commentedComment #17
alexpottCommitted 839caad and pushed to 9.0.x. Thanks!