Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

StatusFileSize
new1.89 KB

Kindly review a patch.

hardik_patel_12’s picture

Assigned: hardik_patel_12 » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3112642-2.patch, failed testing. View results

dhirendra.mishra’s picture

Assigned: Unassigned » dhirendra.mishra

@hardik, Comment there in code itself explain that we had converted from array to string as "The possibility to pass an array as source value to the plugin will be removed in drupal:9.0.0. Pass a string value instead." So we don't have to remove entire code. As test case failed due to removing of reset() from your patch as $value is array.

dhirendra.mishra’s picture

Assigned: dhirendra.mishra » Unassigned
Status: Needs work » Needs review
StatusFileSize
new627 bytes
new1.92 KB

Please review updated patch.

nishantghetiya’s picture

Assigned: Unassigned » nishantghetiya
nishantghetiya’s picture

Status: Needs review » Reviewed & tested by the community

@dhirendra.mishra @Hardik_Patel_12, #6 patch works fine. Thanks for your valuable contribution.

nishantghetiya’s picture

Assigned: nishantghetiya » Unassigned
alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/menu_link_content/src/Plugin/migrate/process/LinkUri.php
@@ -90,9 +90,7 @@ public static function create(ContainerInterface $container, array $configuratio
     if (is_array($value)) {
       $value = reset($value);
-      @trigger_error('Passing an array as source value into the link_uri migrate process plugin is deprecated in drupal:8.8.0. The possibility to pass an array as source value to the plugin will be removed in drupal:9.0.0. Pass a string value instead. See https://www.drupal.org/node/3043694', E_USER_DEPRECATED);
     }

We need to remove the entire if here. That behaviour is deprecated. And remove the corresponding test - i.e. \Drupal\Tests\menu_link_content\Kernel\Plugin\migrate\process\LinkUriTest::testRoutedLegacy()

dhirendra.mishra’s picture

Assigned: Unassigned » dhirendra.mishra
dhirendra.mishra’s picture

Assigned: dhirendra.mishra » Unassigned
Status: Needs work » Needs review
StatusFileSize
new734 bytes
new2.13 KB

Fixed as per mentioned in #10 and interdiff from #2 patch.

hash6’s picture

Assigned: Unassigned » hash6
hash6’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @dhirendra.mishra , I see the suggestions by @alexpott have been successfully applied in patch.

hash6’s picture

Assigned: hash6 » Unassigned
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 839caad and pushed to 9.0.x. Thanks!

  • alexpott committed 839caad on 9.0.x
    Issue #3112642 by dhirendra.mishra, Hardik_Patel_12, alexpott: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.