Remove stale reference to datetime_range_view_presave() [#3112641]

Comment	File	Size	Author
#6	interdiff_2-6.txt	846 bytes	leolandotan
#6	3112641-6.patch	846 bytes	leolandotan
9.0.x: PHP 7.3 & MySQL 5.7 27,250 pass, 1 fail PHP 7.3.x-dev & MySQL 5.7 27,252 pass
#2	3112641-2.patch	6.26 KB	Hardik_Patel_12
9.0.x: PHP 7.3 & MySQL 5.7 27,376 pass

Comment #1

11 February 2020 at 05:13

Hardik_Patel_12 created an issue. See original summary.

Log in or register to post comments

Comment #2

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commented 11 February 2020 at 05:14

File	Size
3112641-2.patch	6.26 KB
9.0.x: PHP 7.3 & MySQL 5.7 27,376 pass

Kindly review a patch.

Log in or register to post comments

Comment #4

hash6 CreditAttribution: hash6 at QED42 for Drupal India Association commented 13 February 2020 at 06:16

Assigned:

Unassigned

» hash6

Log in or register to post comments

Comment #5

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 1 May 2020 at 00:31

Title:	Remove all @deprecated code from datetime_range module	» Remove stale reference to datetime_range_view_presave()
Status:	Needs review	» Needs work

datetime_range_view_presave() was already removed in a different issue. However, the other issue didn't fix the @see (the second hunk of this patch). So, can we create a new patch with only the second hunk? Thanks!

Log in or register to post comments

Comment #6

leolandotan CreditAttribution: leolandotan as a volunteer and at Promet Source commented 1 May 2020 at 01:42

Status:

Needs work

» Needs review

File	Size
3112641-6.patch	846 bytes
9.0.x: PHP 7.3 & MySQL 5.7 27,250 pass, 1 fail PHP 7.3.x-dev & MySQL 5.7 27,252 pass
interdiff_2-6.txt	846 bytes

Hi! I went ahead and updated the patch by doing a re-roll because the patch in #2 didn't cleanly apply to the latest 9.0.x code base anymore.

I tested the patch using `➜ drupal git:(9.0.x) ✗ git apply --check 3112641-6.patch` and there was no output so I think this is alright.

I just went and added an interdiff even if the path and the interdiff looks the same.

Hope everything is in order.

Thank you!

Log in or register to post comments

Comment #7

1 May 2020 at 02:45

Status:

Needs review

» Needs work

The last submitted patch, 6: 3112641-6.patch, failed testing. View results

Log in or register to post comments

Comment #8

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented 1 May 2020 at 11:57

Adding patch shared in #6 for retesting.

I have added this patch to my local and tested it after applying the patch. For me, this test case worked in local.

Local drupal version: 9.0.x
Local PHPUnit version: 8.5.4
PHP version: 7.3.17

root@3b1a1f78358c:/var/www/html# ./vendor/bin/phpunit -c core/phpunit.xml core/modules/media_library/tests/src/FunctionalJavascript/WidgetUploadTest.php
PHPUnit 8.5.4 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\media_library\FunctionalJavascript\WidgetUploadTest
SS                                                                  2 / 2 (100%)

Time: 4.11 minutes, Memory: 8.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 2, Assertions: 2, Skipped: 2.

Thanks,
Sandesh Jain.

Log in or register to post comments

Comment #9

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented 1 May 2020 at 12:00

Assigned:	hash6	» sja112
Status:	Needs work	» Needs review

Log in or register to post comments

Comment #10

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented 1 May 2020 at 13:05

Status:

Needs review

» Reviewed & tested by the community

This patch applied smoothly and passed all the test cases. So, moving this to Reviewed and Tested by the community.

Log in or register to post comments

Comment #11

sja112 CreditAttribution: sja112 at Srijan | A Material+ Company for Drupal India Association commented 1 May 2020 at 13:10

Assigned:

sja112

» Unassigned

Log in or register to post comments

Comment #12

1 May 2020 at 21:09

xjm committed 95ff62a on 9.1.x

Issue #3112641 by leolando.tan, Hardik_Patel_12, xjm: Remove stale...

Log in or register to post comments

Comment #13

1 May 2020 at 21:09

xjm committed 08c39a3 on 9.0.x

Issue #3112641 by leolando.tan, Hardik_Patel_12, xjm: Remove stale...

Log in or register to post comments

Comment #14

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 1 May 2020 at 21:09

Status:

Reviewed & tested by the community

» Fixed

Thanks for working on this!

@sja112, The automated testing infrastructure tells us whether the patch applies and passes tests, so we do not need people to review that. What we need people to review is whether the change is correct and complete. :)

In this case, the docs referred to a removed hook implementation for which there was no direct replacement, so simply removing the stale docs is sufficient to resolve the issue.

Committed to 9.1.x and 9.0.x. Thanks!