CommentFileSizeAuthor
#6 interdiff-3112638-3-6.txt2.03 KBhardik_patel_12
#6 3112638-6.patch6.18 KBhardik_patel_12
#3 3112638-3.patch4.25 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3112638-3.patch4.25 KB
hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 3112638-3.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3112638-6.patch6.18 KB
new interdiff-3112638-3-6.txt2.03 KB

Kindly review a new patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
nishantghetiya’s picture

nishantghetiya commented
Assigned: Unassigned » nishantghetiya
nishantghetiya’s picture

nishantghetiya commented

Hi @Hardik_Patel_1,

Patch #6 LGTM + 1 RTBC

Thanks for your contribution.

nishantghetiya’s picture

nishantghetiya commented
Assigned: nishantghetiya » Unassigned
Status: Needs review » Reviewed & tested by the community
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented 
  1. +++ b/core/lib/Drupal/Core/Cache/Context/UserRolesCacheContext.php
@@ -27,13 +27,6 @@ public static function getLabel() {
-    // User 1 does not actually have any special behavior for roles; this is
-    // added as additional security and backwards compatibility protection for
-    // SA-CORE-2015-002.
-    // @todo Remove in Drupal 9.0.0.
-    if ($this->user->id() == 1) {
-      return 'is-super-user';
-    }

    We should double check that this is safe to remove as this is security related. 

  2. +++ b/core/tests/Drupal/Tests/Core/Cache/CacheTest.php
@@ -40,22 +40,6 @@ public function validateTagsProvider() {
-   * @dataProvider validateTagsProvider

    The data provider can probably also be removed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work
indrapatil’s picture

indrapatil commented
Assigned: Unassigned » indrapatil
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Closed (duplicate)

This was done as part of a wider issue in #3104307: Remove BC layers in various Drupal\Core components

indrapatil’s picture

indrapatil commented
Assigned: indrapatil » Unassigned