Closed (fixed)
Project:
Drupal core
Version:
9.0.x-dev
Component:
asset library system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Feb 2020 at 08:55 UTC
Updated:
29 Feb 2020 at 07:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKindly apply a new patch.
Comment #3
hardik_patel_12 commentedComment #4
swatichouhan012 commented@Hardik_Patel_12 Can you please add screenshot before and after patch, I checked without patch apply here is no issue in asset.
Comment #5
hash6 commentedComment #6
hash6 commentedThanks @Hardik_Patel_12, for the patch.
@swatichouhan012 FileSystemInterface before Drupal 9.x was optional and is required now
drupal-check somehow did not detect it.
Comment #7
longwaveThis whole method can be refactored away now.
Comment #8
hash6 commentedComment #9
hash6 commentedComment #10
longwaveThis does duplicate some work done in #3104307: Remove BC layers in various Drupal\Core components
There is a remaining @todo in AssetResolver::getCssAssets() - not sure how or when this was deprecated:
Comment #11
prabha1997 commentedI am working on this issue
Comment #12
prabha1997 commentedComment #14
longwaveI was wrong about #10 as this needs properly deprecating in #3069052: Properly deprecate the stylesheets-remove key from theme info.yml files. first, so we can't remove it yet.
Reuploading #9 and marking it RTBC.
Comment #15
alexpottThe $libraries_directory_file_finder deprecation stuff shouldn't be removed. This is an 8.9.x deprecation for Drupal 10.
Comment #16
hardik_patel_12 commentedKindly review a new patch.
Comment #17
hardik_patel_12 commentedComment #18
andypostBack to RTBC as remaining method use own issue #3069052: Properly deprecate the stylesheets-remove key from theme info.yml files.
Comment #19
andypostComment #20
alexpottCommitted 617441c and pushed to 9.0.x. Thanks!
Fixed on coding standard on commit.