System module's REGIONS_VISIBLE and REGIONS_ALL constants were deprecated as part of #2807785: Move global constants from *.module files into interfaces but the deprecation didn't account for the fact that these constants are used in system.module and the block module is not required.
Undeprecate the constants and let #3015812: Introduce new Theme extension object and properly deprecate REGIONS_VISIBLE and REGIONS_ALL resolve the fact we now have both REGIONS_VISIBLE and \Drupal\block\BlockRepositoryInterface::REGIONS_VISIBLE
On commit update https://www.drupal.org/node/2831620
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3112263-4.patch | 808 bytes | alexpott |
| #2 | 3112263-2.patch | 1.45 KB | alexpott |
Comments
Comment #2
alexpottComment #4
alexpottSo let's not change the \Drupal\block\BlockRepositoryInterface here - doesn't really matter and #3015812: Introduce new Theme extension object and properly deprecate REGIONS_VISIBLE and REGIONS_ALL can deal with cleaning this mess up. Note that \Drupal\block\BlockRepositoryInterface::REGIONS_VISIBLE and \Drupal\block\BlockRepositoryInterface::REGIONS_ALL are completely unused in runtime code. The reason tests fail is because they're unit and don't include system.module.
Comment #5
gábor hojtsyLooks fine. Change record can only be updated on/after commit.
Comment #8
catchCommitted f0d7d73 and pushed to 9.0.x. Cherry-picked to 8.9.x and 8.8.x. Thanks!