Steps to reproduce

  1. create node with paragraph which contains multiple (limited by 5 for ex) entity reference field with following settings

    2. settings

    or

    settings

Current result

  • There are 3 crosses for each field
  • Main cross is vertically centered with fields (this issue is reproduced for any paragraph)

issue

Expected result

  • Should be 1 cross for each field
  • The main cross should be placed on the top left, as on default theme.

expected result

CommentFileSizeAuthor
#18 paragraphs-cross-positioning-3112245-18.patch735 bytesgrask0
#16 Screenshot 2022-05-17 at 11.18.36 PM.png11.22 KBjoshua1234511
#14 paragraphs-cross_after-patching.jpg104.01 KBLegmo
#12 paragraphs-cross-positioning-3112245-10.patch630 bytesLegmo
selected_7785.png45.07 KBKondratievaS
selected_7784.png13.93 KBKondratievaS
selected_7783.png23.73 KBKondratievaS
selected_7781.png116.9 KBKondratievaS

Comments

KondratievaS created an issue. See original summary.

KondratievaS’s picture

KondratievaS commented

First issue is fixed in https://www.drupal.org/project/drupal/issues/3092181

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3129871: Incorrect targetElement.className value when dragging table rows between regions, +#3145188: Paragraphs fields cause overflow of content forms in Claro
andypost’s picture

andypost
he/him
Primary language Russian
commented

the related was closed but second problem from IS remains #3092181: Nested Paragraphs create multiple drag handles

andypost’s picture

andypost
he/him
Primary language Russian
commented
Project: Drupal core » Paragraphs
Version: 9.4.x-dev » 8.x-1.x-dev
Component: Claro theme » Code

Moving to source of issue, probably it needs to fix css\paragraphs.widget.scss

saschaeggi’s picture

saschaeggi
he/him
commented
Related issues: +#3204862: Backport tabledrag.js for Drupal 8.8+

Maybe it's worth looking at how we solved this issue over at Gin: #3204862: Backport tabledrag.js for Drupal 8.8+

Legmo’s picture

Legmo commented

Fixed vertical positioning of cross - now it is at the top, not in the middle.

I draw your attention - in the previous patch, this positioning was changed for some reason (it was top - it became middle).
Why - I don't know.

Legmo’s picture

Legmo commented

Fixed vertical positioning of cross - now it is at the top, not in the middle.

I draw your attention - in the previous patch, this positioning was changed for some reason (it was top - it became middle).
Why - I don't know.

Legmo’s picture

Legmo commented
StatusFileSize
new paragraphs-cross-positioning-3112245-10.patch630 bytes
Legmo’s picture

Legmo commented
Status: Active » Needs review
Legmo’s picture

Legmo commented
StatusFileSize
new paragraphs-cross_after-patching.jpg104.01 KB
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Needs manual testing

Change itself is simple but this needs manual testing from someone other than the patch creator so tagging.

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing
StatusFileSize
new Screenshot 2022-05-17 at 11.18.36 PM.png11.22 KB

Patch handles the issue noted in the issue summary and nothing else.
Patch applied cleanly #12
Test passes
I have conducted manual test and it works as expected.
After Patch

flyke’s picture

flyke commented

Patch does not apply to Drupal 11.3.2

grask0’s picture

grask0 commented
StatusFileSize
new paragraphs-cross-positioning-3112245-18.patch735 bytes

Hello, here is the updated patch.