Problem/Motivation

In #3110296: Remove all @deprecated code from Drupal/Core/Access/ we intend to remove AccessResult::cacheUntilEntityChanges() in Drupal 9. However, it was deprecated early in the D8 cycle and never had a trigger_error() deprecation notice added to warn developers. We should add this now before it is removed.

Proposed resolution

Add trigger_error() pointing developers to the change notice.

Remaining tasks

Patch, test, commit.

User interface changes

None

API changes

An already deprecated API will log a deprecation error.

Data model changes

None

Release notes snippet

CommentFileSizeAuthor
#4 3111504-4.patch2.31 KBandypost
#4 interdiff.txt980 bytesandypost
#3 3111504.patch2.29 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Title: Properly deprecated AccessResult::cacheUntilEntityChanges() » Properly deprecate AccessResult::cacheUntilEntityChanges()
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Active » Needs review
FileSize
3111504.patch2.29 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3069028: Properly Deprecate Drupal\Core\Access\AccessResult::cacheUntilConfigurationChanges
FileSize
interdiff.txt980 bytes
3111504-4.patch2.31 KB

Entity class is deprecated and the method expects interface

PS: patch is the same as in related issue #3069028: Properly Deprecate Drupal\Core\Access\AccessResult::cacheUntilConfigurationChanges

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks good.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Committed c2ee4cd and pushed to 8.9.x. Cherry-picked to 8.8.x. Thanks!

  • catch committed f6cd86e on 8.9.x 
    Issue #3111504 by andypost, longwave, Berdir: Properly deprecate...

  • catch committed 1643a70 on 8.8.x 
    Issue #3111504 by andypost, longwave, Berdir: Properly deprecate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.