Problem/Motivation

#3107732: Add return typehints to setUp/tearDown methods in concrete test classes introduced void return typehints in setUp, tearDown and other PHPUnit TestCase inherited methods to comply with PHPUnit 8 declarations, for Drupal core test code.

However, that is not enforced yet, and we need to contributors that they have to adjust their test classes.

Proposed resolution

Deprecate named methods conditionally on not having a void return typehint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

mondrake created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@mondrake thanks for filing this issue - it'd be great to add the deprecation code as a proof-of-concept to #3107732: Add return typehints to setUp/tearDown methods in concrete test classes but then remove it prior to commit- and then copy that hunk of code to this issue.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Postponed » Fixed

This was done directly in the 9.1.x patch of #3107732: Add return typehints to setUp/tearDown methods in concrete test classes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.