I came across the issue that if you enter a field description and disable opacity input, the description appears twice in the field widget.

Also, I think wrapping the widget in a fieldset is not neccesary (and not beneficial) without opacity, it would only include a single field.

CommentFileSizeAuthor
#12 color-wrong.jpg11.62 KBrwam
#12 color-correct.jpg17.73 KBrwam
#6 double-field-description-3111039-6.patch523 bytesbalintbrews
#3 double-field-description-3111039-3.patch483 byteskmetz

Comments

kmetz created an issue. See original summary.

kmetz’s picture

kmetz commented
Issue summary: View changes
kmetz’s picture

kmetz commented
StatusFileSize
new double-field-description-3111039-3.patch483 bytes
bartlangelaan’s picture

bartlangelaan
Primary language Dutch
Location Netherlands
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: double-field-description-3111039-3.patch, failed testing. View results

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
StatusFileSize
new double-field-description-3111039-6.patch523 bytes

I ran into the same issue. Thank you for the patch, @kmetz. Here is my slightly adjusted version which still renders the container element around the field so that JavaScript logic that expects that markup (i.e. Drupal.behaviors.color_field_spectrum) doesn't break.

lonalore’s picture

lonalore
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs work » Reviewed & tested by the community

Patch from #6 works perfectly. Thank you!

dunebl’s picture

dunebl
Primary language French
commented

I confirm tha #6 is perfect!
Thank you

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch and testing, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rwam’s picture

rwam commented
StatusFileSize
new color-correct.jpg17.73 KB
new color-wrong.jpg11.62 KB

Sorry, but this patch breaks the spectrum widget.

EXPECTED BEHAVIOR using $element['#type'] = 'fieldset';

correct display

CURRENT BEHAVIOR using $element['#type'] = 'container';

wrong display

@NickDickinsonWilde - can this issue be reopened or should I create a new ticket?