Closed (fixed)
Project:
Simple Iubenda
Version:
8.x-1.0-alpha1
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2020 at 16:04 UTC
Updated:
27 Feb 2020 at 10:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
greg.zielinski commentedComment #3
sophie.skI only have one tiny bit of feedback:
Since the default value in config/install/iubenda.settings.yml is 1, I would suggest this default value is set to TRUE.
Otherwise, this looks good! :D Thank you!
Comment #4
greg.zielinski commentedComment #5
sophie.skThanks for the speedy updates!
One other thing I realised: if this is a config update, then there should be a module update to create this value on existing installations. I just realised that the patch in #3104605: Disable banner on admin pages doesn't have an update hook either, I should update that.
Comment #6
sophie.skAdding updated patch. It turns out I totally added an update hook for the other ticket, so I just tagged onto that one, as they'll form the same release.
Comment #8
sophie.skAaand fixed. Thanks :)