Currently styling of the banner is fully external. Documentation gives an option to override this behaviour. This could come as a flag in configuration

Comments

greg.zielinski created an issue. See original summary.

greg.zielinski’s picture

sophie.sk’s picture

I only have one tiny bit of feedback:

+++ b/src/Form/IubendaSettingsForm.php
@@ -127,6 +127,13 @@ class IubendaSettingsForm extends ConfigFormBase {
+      '#default_value' => $config->get('iubenda_cookies.settings.apply_styles') ?: FALSE,

Since the default value in config/install/iubenda.settings.yml is 1, I would suggest this default value is set to TRUE.

Otherwise, this looks good! :D Thank you!

greg.zielinski’s picture

sophie.sk’s picture

Thanks for the speedy updates!

One other thing I realised: if this is a config update, then there should be a module update to create this value on existing installations. I just realised that the patch in #3104605: Disable banner on admin pages doesn't have an update hook either, I should update that.

sophie.sk’s picture

Status: Active » Reviewed & tested by the community
StatusFileSize
new2.14 KB

Adding updated patch. It turns out I totally added an update hook for the other ticket, so I just tagged onto that one, as they'll form the same release.

  • Sophie.SK committed f3fe9ef on 8.x-1.x
    Issue #3110823 by greg.zielinski, Sophie.SK: Ability to apply own CSS
    
sophie.sk’s picture

Status: Reviewed & tested by the community » Fixed

Aaand fixed. Thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.