Error: Call to a member function addError() on null in Drupal\slack\Slack->sendMessage()

CommentFileSizeAuthor
#8 interdiff-4-8.txt480 bytestr
#8 3110719-8-messenger-not-initialized.patch1.45 KBtr
#4 fix-for-adderror-3110719.patch1.43 KBbinnythomas

Comments

binnythomas created an issue. See original summary.

binnythomas’s picture

binnythomas commented
Title: Error: Call to undefined method Drupal\\slack\\Slack::messenger() in Drupal\\slack\\Slack->sendMessage() » Error: Call to a member function addError() on null in Drupal\slack\Slack->sendMessage()
Issue summary: View changes
binnythomas’s picture

binnythomas commented
Assigned: Unassigned » binnythomas
binnythomas’s picture

binnythomas commented
StatusFileSize
new fix-for-adderror-3110719.patch1.43 KB

Attaching patch with a fix.

binnythomas’s picture

binnythomas commented
Status: Needs work » Needs review
binnythomas’s picture

binnythomas commented
Assigned: binnythomas » Unassigned
tr’s picture

tr commented
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

This error only happens if you have not set the slack_webhook_url configuration variable and are trying to send a slack message using this module's service.

This error does not happen with the test form because the test form checks the configuration variable and does not try to send the message if the variable is empty.

The patch in #4 still applies and fixes the error. RTBC.

tr’s picture

tr commented
StatusFileSize
new 3110719-8-messenger-not-initialized.patch1.45 KB
new interdiff-4-8.txt480 bytes

Fixed a trivial coding standards error.

  • adci_contributor committed e6d8106 on 8.x-1.x authored by TR 
    Issue #3110719 by TR, binnythomas: Error: Call to a member function...
adci_contributor’s picture

adci_contributor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.