Currently, the theme CSS references Gov UK images within the node_modules directory, however if you're not compiling the CSS yourself and installing the dependencies, they won't work.

The Gulp script should be modified to include a task which extracts the images from within node_modules and moves them into an assets folder within the theme, and they should be committed into the repository by default.

The new assets folder should then be referenced from within the templates where necessary, though the directory twig variable should be changed to always reference the GovUK theme itself (and not a child if extended).

I've added a patch which implements this, though the assets need to be regenerated and committed (CSS and images/fonts).

Comments

sufi.gaffar created an issue. See original summary.

sufi.gaffar’s picture

StatusFileSize
new4.55 KB

Fix issue with patch not applying

sufi.gaffar’s picture

sufi.gaffar’s picture

StatusFileSize
new4.55 KB

Update line endings to LF

webfaqtory’s picture

webfaqtory’s picture

Status: Active » Needs review
avpaderno’s picture

Status: Needs review » Needs work
rithesh bk’s picture

Assigned: Unassigned » rithesh bk
Issue tags: +VbContribution2020

we will work on VbContribution2020 ...

rithesh bk’s picture

Assigned: rithesh bk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new3.86 KB

Please find the updated patch ........

sufi.gaffar’s picture

#9 looks good to me, built successfully.

sufi.gaffar’s picture

Status: Needs review » Fixed
avpaderno’s picture

Status: Fixed » Needs review

It's not fixed until the patch is committed. Also, the patch didn't pass the tests.

sufi.gaffar’s picture

The patch was committed - see https://git.drupalcode.org/project/govuk_theme/commit/f9a0dcbe2f3aed2dbb.... I'm not sure why it didn't show up in this thread, but it's there.

webfaqtory’s picture

Status: Needs review » Reviewed & tested by the community

webfaqtory’s picture

Status: Reviewed & tested by the community » Fixed
webfaqtory’s picture

Status: Fixed » Closed (fixed)