Currently, the theme CSS references Gov UK images within the node_modules directory, however if you're not compiling the CSS yourself and installing the dependencies, they won't work.
The Gulp script should be modified to include a task which extracts the images from within node_modules and moves them into an assets folder within the theme, and they should be committed into the repository by default.
The new assets folder should then be referenced from within the templates where necessary, though the directory twig variable should be changed to always reference the GovUK theme itself (and not a child if extended).
I've added a patch which implements this, though the assets need to be regenerated and committed (CSS and images/fonts).
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3110071-9.patch | 3.86 KB | rithesh bk |
| #4 | 311071-4.patch | 4.55 KB | sufi.gaffar |
Comments
Comment #2
sufi.gaffar commentedFix issue with patch not applying
Comment #3
sufi.gaffar commentedComment #4
sufi.gaffar commentedUpdate line endings to LF
Comment #5
webfaqtory commentedComment #6
webfaqtory commentedComment #7
avpadernoComment #8
rithesh bk commentedwe will work on VbContribution2020 ...
Comment #9
rithesh bk commentedPlease find the updated patch ........
Comment #10
sufi.gaffar commented#9 looks good to me, built successfully.
Comment #11
sufi.gaffar commentedComment #12
avpadernoIt's not fixed until the patch is committed. Also, the patch didn't pass the tests.
Comment #13
sufi.gaffar commentedThe patch was committed - see https://git.drupalcode.org/project/govuk_theme/commit/f9a0dcbe2f3aed2dbb.... I'm not sure why it didn't show up in this thread, but it's there.
Comment #14
webfaqtory commentedComment #16
webfaqtory commentedComment #17
webfaqtory commented