t() calls should be avoided , use $this->t() instead in Config module

Confirmed the only remaining t() calls are in config.module and tests, so this is good to go.

+1 RTBC.

Fix one more place

Good spot on that untranslated string :)

core/modules/config/tests/config_test/src/ConfigTestForm.php
\Drupal\config_override_test\Cache\PirateDayCacheContext::getLabel
\Drupal\config_override_integration_test\Cache\ConfigOverrideIntegrationTestCacheContext::getLabel
\Drupal\config_test\ConfigTestListBuilder::buildHeader

Let's update the test module too - people copy test modules so we should set good examples there.

Note leave the use of t() in *Test.php well alone there are other issues about that and it is complicated.

Fixed feedback #14 but now it's not clear about usage in core/modules/config/tests/config_test/src/ConfigTestForm.php this form is supposed to be used in tests only so its translatable strings should not bleed into translations

The patch looks and works fine for me.

+++ b/core/modules/config/src/Controller/ConfigController.php
@@ -15,11 +15,13 @@
 use Drupal\system\FileDownloadController;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\Request;
+use Drupal\Core\StringTranslation\StringTranslationTrait;
 
 /**
  * Returns responses for config module routes.
  */
 class ConfigController implements ContainerInjectionInterface {
+  use StringTranslationTrait;
 

I think we need to decide on the meta what to do here. We use the trait or we can extend ControllerBase. I'm not sure about what is better. I think that extending ControllerBas might future proof changes to these controllers that need normal controller functionality and don't want to jump through service injection hoops.

Adjust patch letting ConfigController to extend ControllerBase, according to #18

Thanks for working on this.

In general, issues should not be scoped by file or module; instead, they should be scoped by making the exact specific change across as much of core as possible. Reference: https://www.drupal.org/core/scope#files

In particular, t() calls should be replaced based on whether the translation service is already available in the class, and more specifically, based on which base class it extends. (So, for example, one issue for form builders, one for controllers, one for list builders, and then splitting that up further only if the resulting patch is too large to be manageable.) We also need to decide the approach before we proceed with child issues. See #3113904: [META] Replace t() calls inside of classes for more discussion. So, closing as a duplicate of the parent issue in #3113904: [META] Replace t() calls inside of classes .

Thanks!