Review of the 8.x-3.x branch (commit 3eb2fca):
Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
./d7exportview.txt: ASCII text, with CRLF line terminators
d7exportview.txt
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.
FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/d7exportview.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 94 WARNINGS AFFECTING 94 LINES
--------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 102 characters
2 | WARNING | Line exceeds 80 characters; contains 100 characters
3 | WARNING | Line exceeds 80 characters; contains 100 characters
4 | WARNING | Line exceeds 80 characters; contains 86 characters
5 | WARNING | Line exceeds 80 characters; contains 119 characters
6 | WARNING | Line exceeds 80 characters; contains 95 characters
16 | WARNING | Line exceeds 80 characters; contains 90 characters
28 | WARNING | Line exceeds 80 characters; contains 81 characters
29 | WARNING | Line exceeds 80 characters; contains 81 characters
46 | WARNING | Line exceeds 80 characters; contains 99 characters
47 | WARNING | Line exceeds 80 characters; contains 82 characters
50 | WARNING | Line exceeds 80 characters; contains 84 characters
53 | WARNING | Line exceeds 80 characters; contains 87 characters
56 | WARNING | Line exceeds 80 characters; contains 83 characters
57 | WARNING | Line exceeds 80 characters; contains 82 characters
58 | WARNING | Line exceeds 80 characters; contains 87 characters
65 | WARNING | Line exceeds 80 characters; contains 98 characters
67 | WARNING | Line exceeds 80 characters; contains 84 characters
68 | WARNING | Line exceeds 80 characters; contains 87 characters
69 | WARNING | Line exceeds 80 characters; contains 86 characters
70 | WARNING | Line exceeds 80 characters; contains 91 characters
73 | WARNING | Line exceeds 80 characters; contains 85 characters
76 | WARNING | Line exceeds 80 characters; contains 83 characters
77 | WARNING | Line exceeds 80 characters; contains 83 characters
78 | WARNING | Line exceeds 80 characters; contains 88 characters
79 | WARNING | Line exceeds 80 characters; contains 87 characters
80 | WARNING | Line exceeds 80 characters; contains 82 characters
82 | WARNING | Line exceeds 80 characters; contains 81 characters
83 | WARNING | Line exceeds 80 characters; contains 84 characters
84 | WARNING | Line exceeds 80 characters; contains 83 characters
85 | WARNING | Line exceeds 80 characters; contains 88 characters
86 | WARNING | Line exceeds 80 characters; contains 81 characters
92 | WARNING | Line exceeds 80 characters; contains 81 characters
93 | WARNING | Line exceeds 80 characters; contains 93 characters
95 | WARNING | Line exceeds 80 characters; contains 86 characters
96 | WARNING | Line exceeds 80 characters; contains 89 characters
97 | WARNING | Line exceeds 80 characters; contains 88 characters
98 | WARNING | Line exceeds 80 characters; contains 93 characters
101 | WARNING | Line exceeds 80 characters; contains 86 characters
104 | WARNING | Line exceeds 80 characters; contains 89 characters
106 | WARNING | Line exceeds 80 characters; contains 82 characters
107 | WARNING | Line exceeds 80 characters; contains 85 characters
108 | WARNING | Line exceeds 80 characters; contains 84 characters
109 | WARNING | Line exceeds 80 characters; contains 89 characters
110 | WARNING | Line exceeds 80 characters; contains 82 characters
113 | WARNING | Line exceeds 80 characters; contains 82 characters
114 | WARNING | Line exceeds 80 characters; contains 92 characters
115 | WARNING | Line exceeds 80 characters; contains 85 characters
117 | WARNING | Line exceeds 80 characters; contains 90 characters
118 | WARNING | Line exceeds 80 characters; contains 97 characters
119 | WARNING | Line exceeds 80 characters; contains 95 characters
120 | WARNING | Line exceeds 80 characters; contains 82 characters
121 | WARNING | Line exceeds 80 characters; contains 88 characters
122 | WARNING | Line exceeds 80 characters; contains 91 characters
123 | WARNING | Line exceeds 80 characters; contains 90 characters
124 | WARNING | Line exceeds 80 characters; contains 95 characters
126 | WARNING | Line exceeds 80 characters; contains 81 characters
127 | WARNING | Line exceeds 80 characters; contains 88 characters
133 | WARNING | Line exceeds 80 characters; contains 93 characters
135 | WARNING | Line exceeds 80 characters; contains 86 characters
136 | WARNING | Line exceeds 80 characters; contains 89 characters
137 | WARNING | Line exceeds 80 characters; contains 88 characters
138 | WARNING | Line exceeds 80 characters; contains 93 characters
141 | WARNING | Line exceeds 80 characters; contains 87 characters
144 | WARNING | Line exceeds 80 characters; contains 90 characters
146 | WARNING | Line exceeds 80 characters; contains 83 characters
147 | WARNING | Line exceeds 80 characters; contains 86 characters
148 | WARNING | Line exceeds 80 characters; contains 85 characters
149 | WARNING | Line exceeds 80 characters; contains 90 characters
152 | WARNING | Line exceeds 80 characters; contains 83 characters
156 | WARNING | Line exceeds 80 characters; contains 87 characters
158 | WARNING | Line exceeds 80 characters; contains 82 characters
160 | WARNING | Line exceeds 80 characters; contains 85 characters
161 | WARNING | Line exceeds 80 characters; contains 87 characters
162 | WARNING | Line exceeds 80 characters; contains 90 characters
164 | WARNING | Line exceeds 80 characters; contains 83 characters
165 | WARNING | Line exceeds 80 characters; contains 86 characters
166 | WARNING | Line exceeds 80 characters; contains 85 characters
167 | WARNING | Line exceeds 80 characters; contains 90 characters
171 | WARNING | Line exceeds 80 characters; contains 86 characters
173 | WARNING | Line exceeds 80 characters; contains 81 characters
175 | WARNING | Line exceeds 80 characters; contains 89 characters
177 | WARNING | Line exceeds 80 characters; contains 82 characters
178 | WARNING | Line exceeds 80 characters; contains 85 characters
179 | WARNING | Line exceeds 80 characters; contains 84 characters
180 | WARNING | Line exceeds 80 characters; contains 89 characters
184 | WARNING | Line exceeds 80 characters; contains 85 characters
185 | WARNING | Line exceeds 80 characters; contains 95 characters
186 | WARNING | Line exceeds 80 characters; contains 88 characters
190 | WARNING | Line exceeds 80 characters; contains 107 characters
191 | WARNING | Line exceeds 80 characters; contains 96 characters
192 | WARNING | Line exceeds 80 characters; contains 104 characters
193 | WARNING | Line exceeds 80 characters; contains 103 characters
194 | WARNING | Line exceeds 80 characters; contains 98 characters
--------------------------------------------------------------------------
FILE: .../drupal/pareviewsh/pareview_temp/src/Controller/ExportController.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
14 | ERROR | [ ] Class property $term_storage should use lowerCamel
| | naming without underscores
51 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
70 | ERROR | [x] Concat operator must be surrounded by a single space
71 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: .../drupal/pareviewsh/pareview_temp/src/Controller/ImportController.php
--------------------------------------------------------------------------
FOUND 15 ERRORS AND 2 WARNINGS AFFECTING 14 LINES
--------------------------------------------------------------------------
31 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
51 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
57 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
59 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
68 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
103 | ERROR | [x] Short array syntax must be used to define arrays
110 | ERROR | [x] No space found before comment text; expected "//
| | remove whitespace" but found "//remove whitespace"
110 | ERROR | [x] Inline comments must start with a capital letter
110 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
195 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
199 | ERROR | [x] Whitespace found at end of line
201 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
221 | ERROR | [x] Expected one space after the comma, 0 found
222 | ERROR | [x] Expected 1 space after "="; 2 found
222 | ERROR | [x] Expected one space after the comma, 0 found
239 | ERROR | [x] Expected one space after the comma, 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/ImportForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
126 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
127 | ERROR | [x] Expected 1 space after "-"; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/ExportForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Time: 1.48 secs; Memory: 6Mb
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drupal-coding-standard-3109166-3.patch | 13.61 KB | Deepthi kumari |
Comments
Comment #2
Deepthi kumari commentedComment #3
Deepthi kumari commentedFixed coding standard issues. Please review.
Comment #5
el1_1el commentedThanks!