Drupal 9 does not handle db_* functions any more

Nice find! I found a few more with grep, we should probably do all these together:

A reference in \Drupal\Core\Utility\Error::decodeException():

      $db_functions = ['db_query', 'db_query_range'];

A comment in \Drupal\Core\Pager\PagerManagerInterface:

   *   $query = db_select('some_table')
   *     ->extend('Drupal\Core\Database\Query\PagerSelectExtender');

An assertion in \Drupal\Tests\node\Kernel\NodeAccessLanguageAwareTest::testNodeAccessLanguageAware():

    $this->assertEqual(count($nids), 3, 'db_select() returns 3 nodes when no langcode is specified.');

A comment in \Drupal\views\Plugin\views\query\Sql::query():

    // db_select doesn't support to specify the key, so use getConnection directly.

Log is blocker?

+++ b/core/modules/views/src/Plugin/views/query/Sql.php
@@ -1296,7 +1296,7 @@ public function query($get_count = FALSE) {
+    // $connection->select doesn't support to specify the key, so use getConnection directly.

I am not sure we need this comment at all any more, but other than that this looks great, so RTBC from me.

Nice tidy up! @andypost I don't think that #2999962: Unify Database/Log::findCaller and Utility/Error::getLastCaller is a blocker.

Committed 06d496f and pushed to 9.0.x. Thanks!

I agree with @longwave - that comment is unnecessary.

diff --git a/core/modules/views/src/Plugin/views/query/Sql.php b/core/modules/views/src/Plugin/views/query/Sql.php
index b5aa3776b3..59b9eb7e83 100644
--- a/core/modules/views/src/Plugin/views/query/Sql.php
+++ b/core/modules/views/src/Plugin/views/query/Sql.php
@@ -1296,7 +1296,6 @@ public function query($get_count = FALSE) {
     }
 
     // Go ahead and build the query.
-    // $connection->select doesn't support to specify the key, so use getConnection directly.
     $query = Database::getConnection($target, $key)
       ->select($this->view->storage->get('base_table'), $this->view->storage->get('base_table'), $options)
       ->addTag('views')

Removed on commit.