Closed (fixed)
Project:
Drupal core
Version:
8.9.x-dev
Component:
layout_builder.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jan 2020 at 11:09 UTC
Updated:
20 Feb 2020 at 17:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch.
Comment #3
hardik_patel_12 commentedComment #4
hardik_patel_12 commentedComment #5
rogerpfaffQuite simple code change. Tests are working.
Comment #6
catchPeople often specify the key in foreaches for readability, so let's remove these hunks from the patch and open a coding standards issue if we want to standardise one way or the other.
Comment #7
rogerpfaffThe use of the key is not in general defined in the coding standards. The example in the PEAR coding standards shows it with key but all over drupal it is used in both ways. Seems like it is used where the key is needed and if not it is left out. Also in this case the key is not something special needed anywhere. I would say it's ok to keep the hunks.
Comment #8
Rangaswini commentedComment #9
pratik_kambleComment #10
pratik_kambleRerolled patch to keep the key in foreach.
Comment #11
pratik_kambleComment #12
nishantghetiya commentedComment #13
nishantghetiya commented@pratik_kamble Hello,
Your patch is works well. Thanks for your contribution.
Comment #16
catchCommitted 6ef456a and pushed to 9.0.x. Thanks!