From the PAReview report, this line in the README.txt is over 80 characters:

* Configure the Email settings blocker from `/admin/config/email_blocker/emailblockersettings`:

email_blocker.info.yml:

package: 'Custom'

This should be "Mail" or similar.

src/Form/EmailBlockerSettingsForm.php:

  /**
   * {@inheritdoc}
   */
  public function submitForm(array &$form, FormStateInterface $form_state) {
    parent::submitForm($form, $form_state);

    $this->config('email_blocker.emailblockersettings')
      ->set('block_emails', $form_state->getValue('block_emails'))
      ->save();
  }

Is parent::submitForm($form, $form_state); necessary here?

Comments

binnythomas created an issue. See original summary.

binnythomas’s picture

Issue summary: View changes

  • binnythomas committed dd10be0 on 8.x-1.x
    Issue #3108214 by binnythomas: PAReview changes for Security Advisory...
binnythomas’s picture

Status: Active » Fixed

Applied all the changes except for the last part above removing parent:submit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.