Closed (fixed)
Project:
Email Blocker
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
23 Jan 2020 at 09:02 UTC
Updated:
6 Feb 2020 at 09:45 UTC
Jump to comment: Most recent
From the PAReview report, this line in the README.txt is over 80 characters:
* Configure the Email settings blocker from `/admin/config/email_blocker/emailblockersettings`:
email_blocker.info.yml:
package: 'Custom'This should be "Mail" or similar.
src/Form/EmailBlockerSettingsForm.php:
/**
* {@inheritdoc}
*/
public function submitForm(array &$form, FormStateInterface $form_state) {
parent::submitForm($form, $form_state);
$this->config('email_blocker.emailblockersettings')
->set('block_emails', $form_state->getValue('block_emails'))
->save();
}Is parent::submitForm($form, $form_state); necessary here?
Comments
Comment #2
binnythomas commentedComment #4
binnythomas commentedApplied all the changes except for the last part above removing parent:submit.