Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In \Drupal\Core\Test\FunctionalTestSetupTrait::installDefaultThemeFromClassProperty() we determine the default theme for an install profile by reading the it's config/install/system.theme.yml. However profiles can also be installed from config/sync so we should check there too. This allows tests using such an install profile not to have to declare a $defaultTheme property.
Proposed resolution
Check config/sync directory too.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#2 | 3108021-2.patch | 3.7 KB | alexpott |
#2 | 3108021-2.test-only.patch | 2.48 KB | alexpott |
Comments
Comment #2
alexpottComment #4
lauriiiCould we remove the
$defaultTheme
property fromDrupal\FunctionalTests\Installer\InstallerExistingConfigSyncDriectoryProfileMismatchTest
andDrupal\FunctionalTests\Installer\InstallerExistingConfigSyncDirectoryProfileHookInstall
as well?Comment #5
alexpott@lauriii nope - because these use config outside the profile. I debated checking the defined config sync directory so we could but then I feared that this might erroneously pick up unrelated config so I think that that is bad idea.
Comment #6
lauriiiMakes sense. In that case #2 looks good. Thank you!
Comment #9
catchCommitted de6caed and pushed to 9.0.x. Thanks! Backported to 8.9.x
Comment #11
catchAnd to 8.8.x