Add the 'core_version_requirement' key in info.yml and composer.json files

CommentFileSizeAuthor
#6 3107975-5.patch894 bytesankush_03
#4 compatiblity_issue-3107975-4.patch360 bytesankush_03
#3 core-version-requirement-key-3107975-1.patch364 bytesramya balasubramanian
#2 3107975-2.patch861 bytesakashkumar07

Comments

ankushgautam76@gmail.com created an issue. See original summary.

akashkumar07’s picture

akashkumar07 commented
Status: Needs work » Needs review
StatusFileSize
new 3107975-2.patch861 bytes

Please review the patch.

ramya balasubramanian’s picture

ramya balasubramanian commented
StatusFileSize
new core-version-requirement-key-3107975-1.patch364 bytes

Updated the patch. Please have a look

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new compatiblity_issue-3107975-4.patch360 bytes

@Ramya Balasubramanian @AkashkumarOSL

With that requirement, anyone running older Drupal 8 versions would not be able to upgrade to newer versions of Email Blocker, which might not be an ideal UX.

Attached updated patch, please have a look.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented

Forgot to add composer dependency file @ AkashkumarOSL kindly change "drupal/core": "^8.7.7 || ^9" to "drupal/core": "^8.0 || ^9.0" in your patch file and update new one.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3107975-5.patch894 bytes

Added Final patch with all dependency.

binnythomas’s picture

binnythomas commented
Status: Needs review » Fixed

Thanks for the patch. Applying it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.