Fix punctuation in link.schema.yml label

Should the https label below be in the form of a question as well? We should probably be consistent, do we have a standard for this?

@longwave I am not sure there is a standard, but at least the description should be an English phrase/sentence. To me, If the URL should use a secure protocol doesn't seem a phrase an English native speaker would use. I think Does the URL use a secure protocol? sounds better, to me.

+++ b/core/modules/link/config/schema/link.schema.yml
@@ -74,7 +74,7 @@ field.value.link:
-          label: 'Is this URL absolute'

I don't think we have a strict standard.

But a "question mark" here make sense to me.

+          label: 'Should use a secure protocol?'

it's missing the subject. (The sentence should be Should the URL use a secure protocol? even if I think Does the URL use a secure protocol? is better.)

I am working on this issue

I uploaded a patch with required changes for label with proper sentence

Looks great, thanks!

+++ b/core/modules/link/config/schema/link.schema.yml
@@ -74,10 +74,10 @@ field.value.link:
         absolute:
           type: boolean
-          label: 'Is this URL absolute'
+          label: 'Is this URL absolute?'
         https:
           type: boolean
-          label: 'If the URL should use a secure protocol'
+          label: 'Should the URL use a secure protocol?'

Rather than making up new language we could borrow the documentation. This would be the first use of a question mark in boolean type labels in core.

So mapping from the docs in \Drupal\Core\Url::fromUri() which is what these settings map to we get:
Whether to force the output to be an absolute link (beginning with http:)
Whether this URL should point to a secure location

currently working on this issue ......

please review the patch.

-          label: 'Is this URL absolute'
+          label: 'Whether to force the output to be an absolute link (beginning with http:)?'

The question mark is not needed. The other labels don't use a period either.

1. +++ b/core/modules/link/config/schema/link.schema.yml
   @@ -74,10 +74,10 @@ field.value.link:
   +          label: 'Whether to force the output to be an absolute link (beginning with http:)?'
   

   if it is a secure URL, it's beginning with https: , so beginning with http: is not always true.

   if change it to "Whether to force the output to be an absolute link (beginning with http)", without :, both http: and https: are applicable.

   And should link such as ftp://drupal.org/files/projects/drupal-8.8.2.zip be considered here?

2. +++ b/core/modules/link/config/schema/link.schema.yml
   @@ -74,10 +74,10 @@ field.value.link:
   +          label: 'Whether this URL should point to a secure location?'
   

   how about "Whether to use https or not? "

   a secure location is not obvious for me to tell where to use https or http. as the key is https.

I am not a native English speaker, so just posting suggestions.

@kiamlaluno I have removed question mark. thanks for suggestion.
here is the new patch please review.

Whether to force the output to be an absolute link (beginning with http:) and Whether this URL should point to a secure location are taken from the description of the options given in Url::fromUri() as requested from comment #12.

While it's true that Whether to force the output to be an absolute link (beginning with http:) seems to say that a link starting with https: is not an absolute link, Whether to force the output to be an absolute link (beginning with http) would not be correct, since a link starting with http is not absolute. To be absolute, the first part of the link must be the URI scheme, which at least include the colons.

If there is the need to explain what absolute link means, I would use the following labels.

• Whether to force the output to be an absolute link (beginning with http: or https:)
• Whether this URL should point to a secure location (beginning with https:)

Agree with @kiamlaluno, patch adjusted according to #20

Looks good!

Updated the IS too to match what the patch is now doing.

Not sure why the patch is failing but this looks good to me.

The tests are failing because two exceptions.

Drupal\Tests\system\Functional\UpdateSystem\UpdatePathTestBaseFilledTest::testPathAliasProcessing
Exception: Notice: Undefined index: date
update_calculate_project_update_status()() (Line: 503)

Drupal\Tests\config_translation\Functional\ConfigTranslationInstallTest::testConfigTranslation
Exception: Notice: Undefined index: date
update_calculate_project_update_status()() (Line: 503)

They are caused from a undefined index in a function that has not been changed from the patch.

Any blockers to this issue?

The new language implies that if https isn't configured, then the link should not point to a secure location. I think the 'force' language is important here even if we don't use the current wording.

The patch got apply without any issue and the labels descriptions look good to me. Making this as RTBC.
Thank You

Committed fb0ced5 and pushed to 9.1.x. Thanks!

Asking release managers if we can backport this to 8.9.x and 9.0.x.

Discussed with @catch and we agree to cherry-pick this to 8.9.x and 9.0.x