Evaluate Password Policy #2983448: Refactor hook_install logic to expire passwords for existing users patch instead of #2771129: "Field field_last_password_reset is unknown" while importing configuration on site without password_policy activated.

Comments

joestewart created an issue. See original summary.

shrop’s picture

shrop commented
Issue tags: +ContributionWeekend2020

  • shrop committed ad788ef on 8.x-1.x 
    Issue #3107097: Evaluate Password Policy 2983448 patch

shrop credited drupalninja.

shrop’s picture

shrop commented

Related discussion in Mediacurrent Slack around this issue with drupalninja and joestewart

@shrop do we need to update the patch for Guardr? https://www.drupal.org/project/password_policy/issues/2771129
Drupal.orgDrupal.org
"Field field_last_password_reset is unknown" while importing configuration on site without password_policy activated
When importing configuration on site without password_policy activated, I'm getting this error [error] InvalidArgumentException: Field field_last_password_reset is unknown. in /var/www/html/cnas/core/lib/Drupal/Core/Entity/ContentEntityBase.php:471 How to reproduce: 1. Install password_policy 2. Export config with drush config-export 3. Uninstall password_policy 4. Import config with drush config-import
Jul 22nd, 2016

Looks like the latest patch should address the review https://www.drupal.org/project/password_policy/issues/2771129#comment-13... . But there are comments like https://www.drupal.org/project/password_policy/issues/2771129#comment-13... that make it look like #2983448: Remove setting of field_last_password_reset on install is a better solution.

joestewart’s picture

joestewart commented
Status: Active » Needs work

The patch has been rerolled in #2983448-18: Refactor hook_install logic to expire passwords for existing users
https://www.drupal.org/files/issues/2020-03-23/Do_not_set_user_fields_on...

  • shrop committed 43954ac on 8.x-1.x 
    Issue #3107097 by joestewart, shrop, drupalninja: Evaluate Password...
joestewart’s picture

joestewart commented

No testing of functionality but the patch is applying.

Via composer install:

  - Installing drupal/password_policy (dev-3.x 4542567): Cloning 454256795d from cache
  - Applying patches for drupal/password_policy
    https://www.drupal.org/files/issues/2020-03-23/Do_not_set_user_fields_on_install-2983448-17.patch (2983448: Remove setting of field_last_password_reset on install)
joestewart’s picture

joestewart commented
Status: Needs work » Needs review
shrop’s picture

shrop commented
Status: Needs review » Needs work

Thanks Joe!

shrop’s picture

shrop commented
Status: Needs work » Fixed

Tested Password Policy after installing Guardr Project using branch 8.x-test-dev.

Commented that the new patch Joe mentioned works for us in [#13527690]

Next step is to create a new release for Guardr Core.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.