Closed (fixed)
Project:
Drupal core
Version:
8.9.x-dev
Component:
media system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2020 at 06:26 UTC
Updated:
20 Feb 2020 at 14:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch.
Comment #3
hardik_patel_12 commentedComment #4
snehalgaikwad commentedI've tried this patch. Looking good to me. Unused variables are removed.
Comment #5
catchPeople often specify the key regardless of usage in foreach statements for readability. Please remove that hunk from the patch and let's open a coding standards issue if we want to standardise either way.
Comment #6
Rangaswini commentedComment #7
Rangaswini commented@Hardik_Patel_12 and @catch
Updated the patch as per the standards.
Comment #8
hardik_patel_12 commentedComment #9
Rangaswini commented@Hardik_Patel_12 and @catch
Updated the patch as per the standards.
Comment #10
Rangaswini commentedComment #11
Rangaswini commentedComment #12
hash6 commentedComment #13
hash6 commentedThanks @Rangaswini for the patch, I have reviewed the above patch and we can definitely remove the unused variable ,also confirmed it in the community with @longwave as well :)
Comment #14
hash6 commentedComment #15
catchCommitted 3459966 and pushed to 9.0.x. Thanks!