I rerolled the patch against the latest 9.0.x-dev.

CommentFileSizeAuthor
#7 update_manager_di-3106995-7.patch3.5 KBrogerpfaff
#2 3106995-2.patch3.54 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3106995-2.patch3.54 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3106995-2.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented

The failing test isn't related to this patch.

Drupal\Tests\media_library\FunctionalJavascript\WidgetUploadTest::testWidgetUploadAdvancedUi
"image-1.png" not found
Failed asserting that a boolean is not empty.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
rogerpfaff’s picture

rogerpfaff
he/his
Primary language German
Location Munich
commented
Issue summary: View changes
StatusFileSize
new update_manager_di-3106995-7.patch3.5 KB

Rerolled the patch against latest 9.0.x-dev because it did not apply. Update tests ran without problems.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs review » Reviewed & tested by the community

It looks and work perfectly fine for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Can this be merged into #3107003: \Drupal calls should be avoided in classes, use dependency injection instead in core/modules/update/src/Form classes - also we need to deprecate calling the class without the route match object to maintain BC and provide a smooth updatre path.