Closed (fixed)
Project:
Language Hierarchy
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
16 Jan 2020 at 12:40 UTC
Updated:
11 May 2020 at 10:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
WidgetsBurritos commentedUsing the drupal-check tool, I don't actually see any deprecated code in this module.
While the D8.7 cycle is still active, you probably just want this:
If you want to wait until the D8.7 cycle is done (which I believe is in June), you could do this:
However, the 8.7 cycle ends at the same time D9 is launched, so I'd say the first version is probably preferable for now. That's what I've done in some of my other modules.
I've attached a patch for both for you to weigh the options.
As it doesn't appear there is a composer.json file for this module, I believe these are the only changes necessary at this point.
Comment #4
WidgetsBurritos commentedIt seems weird that the build is saying it failed testing, considering there are no tests in the module. Placing back to in review for re-assessment here.
Comment #5
james.williamsOh brilliant!! Thanks for running that report on the module.
Comment #7
james.williamsD9 / semver alpha release on the way :-)