The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Adding HTML 5 Validation for Select-Radio-Checkbox fields automatically on all forms.
This module is made on Drupal 8. Please help me to cover the security advisory policy.
Project link
https://www.drupal.org/project/s_r_c_html5_validation
Git instructions
git clone --branch 8.x-2.x https://git.drupalcode.org/project/s_r_c_html5_validation.git
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-s_r_c_html5_validation.git-8.x-2.x
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | success_image.png | 52.05 KB | rksyravi |
| #7 | src_validation.png | 48.62 KB | ankush_03 |
| #7 | src_download.png | 32.64 KB | ankush_03 |
| #3 | src-pareview.png | 110.37 KB | ankush_03 |
Comments
Comment #2
vernitBelow are error show in pareview. Please fix them before proceed
Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
The s_r_c_html5_validation.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
Comment #3
ankush_03@vernit
8.x-1.x branch pareview is fine Attached screenshot.
Comment #4
ankush_03But Agree with @vernit comment, your readme file is not descriptive (Spelling mistakes and a single line description).
Review and fix it.
Comment #5
rohitrajputsahab commentedComment #6
rohitrajputsahab commented@Vernit Pareview errors and warning is already fixed.
@ankushgautam76@gmail.com Fixed Typo
Comment #7
ankush_03@Rohit,
I have created a new field list text in a content type (Required : true)
Change the display to radio
It is not working (Attached screenshot).
Comment #8
rohitrajputsahab commented@ankushgautam76@gmail.com Please check now.
I have created a new branch. Please take the clone below command.
git clone --branch 8.x-2.x https://git.drupalcode.org/project/s_r_c_html5_validation.git
Comment #9
ankush_03Do not change the status to RTBC Directly.
Comment #10
ankush_03@rohit-drupal
Allow me some time for review.
Comment #11
avpadernoComment #12
rohitrajputsahab commented@ankushgautam76@gmail.com
Sure
Comment #13
rohitrajputsahab commentedHi All,
I'm waiting for your feedback.
Comment #14
rksyraviHi @rohit-drupal,
Your module is working fine, both automated and manually.
Comment #15
rksyraviHi again,
check the attachment. for reference.
Comment #16
rohitrajputsahab commented@rksyravi Thank you
I have changed the status "Reviewed & tested by the community".
Comment #17
rksyraviHi @rohit-drupal,
Since this is your project, so you are not authorized to change the status to RTBC
Comment #18
navodit commented@rohit-drupal
I have tested your module both automated and manual. It's working fine.
Thanks for your contribution.
Comment #19
rohitrajputsahab commented@Navodit Thank you so much.
Comment #20
rohitrajputsahab commentedHi Again,
I'm waiting for user's feedback and updates.
Comment #21
klausiThanks for your contribution!
Why do you need a Javascript file to change HTML 5 form markup? That will not work in browsers that have JS disabled? Why can't you process the form element in PHP and set the attribute there?
Otherwise looks good to me, did not see any security issues.
Comment #22
rohitrajputsahab commented@klausi
If the user using JS disable addon. All JS files stop working, not mine one.
PHP code takes a lot of code to check, which fields are required or not.
So, I compared both things, then I went with JS.
Comment #23
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #24
rohitrajputsahab commentedThank you, everyone, for your comments and suggestions.