t() calls should be avoided in classes, use dependency injection and $this->t() instead in Node module

@Hardik_Patel_12: when you update a patch it is helpful to provide an interdiff against the previous patch so reviewers can easily see what was changed between the patches. See https://www.drupal.org/documentation/git/interdiff for documentation on this.

Thanks @Hardik_Patel_12 for the patch, reviewed and tested successfully.

+++ b/core/modules/node/src/NodeTypeForm.php
@@ -146,20 +146,20 @@ public function form(array $form, FormStateInterface $form_state) {
-      '#description' => t('Users with the <em>Administer content</em> permission will be able to override these options.'),
+      '#description' => $this->t('Users with the <em>Administer content</em> permission will be able to override these options.'),

This is conflicting with a recent change. When re-rolling we need to ensure that the new and not the old text is used.

#16 patch failed to apply, i have rerolled a new one to remove all t calls, kindly review.

Working on this

#15 checked

$ cat 3106762-19.patch | grep "Administer content"
# the output is empty

Should move MigrationDeriverTrait and StringTranslationTrait to DeriverBase? Both D6NodeDeriver and D7NodeDeriver use the two traits.

Thanks for working on this.

In general, issues should not be scoped by file or module; instead, they should be scoped by making the exact specific change across as much of core as possible. Reference: https://www.drupal.org/core/scope#files

In particular, t() calls should be replaced based on whether the translation service is already available in the class, and more specifically, based on which base class it extends. (So, for example, one issue for form builders, one for controllers, one for list builders, and then splitting that up further only if the resulting patch is too large to be manageable.) We also need to decide the approach before we proceed with child issues. See #3113904: [META] Replace t() calls inside of classes for more discussion. So, closing as a duplicate of the parent issue in #3113904: [META] Replace t() calls inside of classes .

Thanks!