Drupal PHP coding standards

Updated the drupal standard please review

An error occurred while applying the patch

Rerolled patch #4 for 8.x-3.x, please review.

Updated the patch in #6 to use $this->getRequest() instead of $this->requestStack in src/Form/ModuleFilterUpdateStatusForm.php file as Drupal\Core\Form\FormBase already implements $this->getRequest().

Thanks!

What we really need here is for automated testing to be enabled on this module. I know there are no functional or kernel tests (yet) but we can run phpcs, csslint, eslint, phpstan if testing was enabled. The module has not had a commit since April 2020, so do we know if it is still actively maintained?

It's a very helpful module, with 226,000 installs, so it would be good to see it continue into Drupal 10.

There are several changes going in right now so this will have to be rechecked.

Moving over credit from https://www.drupal.org/project/module_filter/issues/3167690

Addressed the conflict

If someone is free please test https://www.drupal.org/project/module_filter/issues/3327754

This is good progress, lots of the coding standards have been fixed, but there are still many remaining. They are all in javascript files, so first we need to verify that the source code is being checked against the correct standards.

Also it would be useful for the project to have a phpcs.xml.dist file, so that local standards checking is easier. We can also adjust which sniffs we want the module to use or ignore.

Second MR to investigate the js warnings and add phpcs.xml.dist

@smustgrave Please could you enable drupalci testing on the 4.x branch, then the new MR can be tested. Currently testing is only set for the 8.x-3.x branch it appears, looking at https://www.drupal.org/node/328228/qa

Thanks

Merged the MR.

Have added automated tests for 4.x-dev branch.

Thanks for the commit and for setting up tests at 4.x

I've raised #3331002: [META] Javascript and YML coding standards as a follow-up for the javascript problems.

After adding the phpcs.xml.dist coding standards config, the project is now checking .md files, which it was not before. There's one coding standards error

module_filter/README.md
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 130 | WARNING | Line exceeds 80 characters; contains 83 characters
     |         | (Drupal.Files.TxtFileLineLength.TooLong)
------------------------------------------------------------------------

It is trivial, but when running phpcs locally to check that a change is clean it always crops up, and just creates a mental overhead to keep ignoring it. It is the only fault reported by phpcs and nice to get it fixed, here's a patch. The links are allowed to extend beyond 80 chars when formatted properly using the [text](url) syntax.

The patch result https://www.drupal.org/pift-ci-job/2564371 shows that the patched readme.md is clean, compared to the error reported at the very end of the list on https://www.drupal.org/pift-ci-job/2564331

Added related issues.

Setting back to NR for the additional patch in #26
This is important because the coding standards failure is causing branch teest to end with grey "Build Successful" instead of green "Pass"

Merged