CommentFileSizeAuthor
#2 3106466-2.patch692 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3106466-2.patch692 bytes

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
hash6’s picture

hash6 commented
Assigned: Unassigned » hash6
Status: Needs review » Reviewed & tested by the community

Thanks @Hardik_Patel_12 Good Catch !!

hash6’s picture

hash6 commented
Assigned: hash6 » Unassigned
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

The typehint is correct. This does have to be a \Drupal\Core\Datetime\DateFormatInterface - we call $entity->setPattern($value); on it in the method.

We could add assert($entity instanceof DateFormatInterface); to make this more explicit.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Closed (duplicate)
Related issues: +#2723621: Fix Drupal.Commenting.FunctionComment.IncorrectTypeHint and Drupal.Commenting.FunctionComment.InvalidTypeHint

Actually this needs to be fixed to be part of #2723621: Fix Drupal.Commenting.FunctionComment.IncorrectTypeHint and Drupal.Commenting.FunctionComment.InvalidTypeHint