Edit form: Configurable address item order [#310624]

Comment #1

AlexisWilke commented 20 September 2008 at 01:07

Now that I have added sub-modules, I can see this problem too, quite a bit.

I think it would be really cool if we could have the same system as for menus & modules (a weight system where -50 is first and +50 is last...) I do not know how easy/hard it would be to add to your existing table of radio buttons. But that's where I would put it!

Thank you.
Alexis Wilke

P.S. this is also a problem without the CCK extension that is.

Log in or register to post comments

Comment #2

AlexisWilke commented 21 September 2008 at 03:25

As a temporary fix, I actually went in the code and added a weight to all the fields. That forces the order automatically (by the Drupal FAPI, Form internal stuff).

Here is the phone entry, see the extra 'weight' field at the end. Make sure to add a comma on the previous line if you do not have one yet.

      'phone' => array(
        'type'        => 'varchar',
        'length'      => 16,
        'description' => t('Phone numbers, like cellphone, home, office'),
        'display'     => ADDRESSES_FIELD_NONE,
        'title'       => t('Phone'),
        'theme'       => array(
          'phone'         => t('Phone number.'),
        ),
        'token'       => 'addresses_general',
	'weight'      => -9
      ),

At this time, ordering the fields in this way is useful only for the setup. In other words, you may not care much. The weight does not carry over to the other forms. For that you need to add a '#weight' in the second part. I suggest the same weight in both places.

    // Telephone number
    if ($fields['phone'] == ADDRESSES_FIELD_HIDDEN) {
      $form['phone'] = array(
        '#type'           => 'hidden',
        '#value'          => isset($values['phone']) ? $values['phone'] : '',
      );
    }
    elseif (!empty($fields['phone'])) {
      $form['phone'] = array(
        '#type'           => 'textfield',
        '#title'          => t('Phone'),
        '#default_value'  => isset($values['phone']) ? $values['phone'] : '',
        '#size'           => 16,
        '#maxlength'      => 75,
        '#attributes'     => NULL,
        '#required'       => ($fields['phone'] == ADDRESSES_FIELD_REQUIRED),
	'#weight'         => -9
      );
    }

Obviously, this is not too good since you need to edit all the files to fix/change the weights... but until a good old fix, it should do for you.

Thank you.
Alexis

Log in or register to post comments

Comment #3

mikepadiernos commented 14 October 2008 at 20:59

I looked within the source and I found out that the output of the form goes by the order within the module itself. I moved it around following the order I liked and it came out properly.