\Drupal calls should be avoided in classes, use dependency injection instead in core/modules/user/src/AccountForm.php class, core/modules/user/src/Access/RegisterAccessCheck.php class and core/modules/user/src/Plugin/Block/UserLoginBlock.php

CommentFileSizeAuthor
#7 3106228-7.patch6.91 KBhardik_patel_12
#2 use_DI-3106228-2.patch2.34 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new use_DI-3106228-2.patch2.34 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: Unassigned » hardik_patel_12
Status: Needs review » Needs work
hardik_patel_12’s picture

hardik_patel_12 commented

combining 2 issues #3106241 : \Drupal calls should be avoided in classes, use dependency injection instead in AccountForm.php and #3106232 : \Drupal calls should be avoided in classes, use dependency injection instead in RegisterAccessCheck.php file

hardik_patel_12’s picture

hardik_patel_12 commented
Title: \Drupal calls should be avoided in classes, use dependency injection instead » \Drupal calls should be avoided in classes, use dependency injection instead in user module
Issue summary: View changes
hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3106228-7.patch6.91 KB

Kindly review a new patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Closed (duplicate)

Thank you for filing this and for your contributions so far.

I am closing this as a duplicate of #2729597: [meta] Replace \Drupal with injected services where appropriate in core. You can use the work in the patches from this and similar issues as starting points for new issues scoped by concept.