I just realized, that embed was updated in December ... and the now handle the icons with data from the DB.
So the icon.data (see https://www.drupal.org/files/issues/2019-12-28/interdiff_5_9.txt from #3101777: Fill in the media_directories_editor module skeleton) was probably working with the latest version of embed.
Let's migrate to that, maybe old style should also be supported .. ?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | media_directories_embed_button_3106183_6.patch | 2.16 KB | rang501 |
| #5 | media_directories_embed_button_3106183_5.patch | 1.53 KB | rang501 |
Comments
Comment #2
ytsurkComment #3
rang501 commentedYes, I took the latest Embed version because the old version required fixed paths which is hard to set because we can't be sure where this module is installed, it can be different from the default.
I'm not sure if we need to add an upgrade path - this button didn't exist in alpha release and came at a similar time while the new Embed was released, but we should probably specify Embed module minimum version.
Comment #4
ytsurkI changed back to the old-style, w/o the use of the EmbedButton, so the config ends up having a reference to a file, and not the icon-data .. so this should be changed back to your config code!
Comment #5
rang501 commentedOk, here is the fixed version, which includes correct icon. I would skip creating an upgrade path here, as this is a new feature that didn't exist in alpha release and the user who has already installed dev version, can always use the icon inside the module.
Comment #6
rang501 commentedForgot to add minimum embed version, also, while being there, fixed description, it didn't show on Extend page.
Comment #7
rang501 commentedComment #8
ytsurkI guess the install stuff needs also to be removed ..
Comment #10
ytsurkRemoved the install hook and fixed an error in the update hook.