Closed (outdated)
Project:
Drupal core
Version:
9.4.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jan 2020 at 08:46 UTC
Updated:
1 Apr 2022 at 05:37 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch
Comment #3
hardik_patel_12 commentedComment #5
hardik_patel_12 commentedKindly review a new patch.
Comment #6
hardik_patel_12 commentedComment #8
dhirendra.mishra commentedComment #9
dhirendra.mishra commentedclass was missing implementing interface. Just fixed that in this patch.
Comment #11
sja112 commentedComment #12
sja112 commentedPatch updated.
Comment #13
sja112 commentedComment #15
sja112 commentedUpdated the last submitted patch.
Type hint "\Drupal\views\Plugin\views\ViewsHandlerInterface" missing for $handler. This is not correct as $handler is a stdClass object containing the value and operator properties. There is a "breakString" method in the "ViewsHandlerInterface" which is used to break x,y,z, and x+y+z into an array and $handler object is the result of this method.
Updated the code accordingly. Please review.
Comment #16
sja112 commentedComment #17
hardik_patel_12 commented@sja112 thankyou for the patch , but it would great if you provide interdiff also along with the patches. This will help others to track what exactly progress is going on the issue.
Comment #18
sja112 commentedAdding interdiff file.
Comment #19
andypostAdded summary, I bet the issue is to add interface for assert, let's see this scope (how many tests will fail)
Probably we can't change argument but
Comment #20
andypostComment #22
pavnish commentedWorking on it
Comment #23
pavnish commented@andypost could you please review this patch .
Comment #24
pavnish commentedComment #25
lendudeThe scope here has become very unclear. This could do with a title and IS update to make it clearer what we are trying to fix, a lot of unrelated clean up seems to have snuck into the patch
Comment #27
pavnish commentedSorry the changes #23 is not working
Comment #28
kishor_kolekar commentedI agree with @sja112
its returning object of Drupal\Tests\views\Functional\Handler\HandlerTest
so its good to remove @param \Drupal\views\Plugin\views\ViewsHandlerInterface $handler from
protected function assertEqualValueComment #29
andypost@kishor_kolekar that's why assert should use interface
Comment #30
andypostUpdated doc block and added ref to interface that defines result of handler
Added extra assertions for it,
@pavnish the problem with your patch is a lot of unrelated changes when issue exactly about doc block, please check the guide to clarify https://www.drupal.org/core/scope#creep
PS: interdiff from #19, fixed IS
Comment #31
pavnish commented@andypost I agree with your comment .
Comment #35
quietone commentedThis has become outdated. The method for which the documentation is being updated was removed in #3231781: [D9.3 beta - w/c Nov 8, 2021] Remove remaining uses of t() in tests
Thanks!